Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Remove ContextLine without source code available #223

Merged
merged 1 commit into from
Jun 3, 2019

Conversation

bruno-garcia
Copy link
Member

ContextLine is expected to be used when source is available (e.g within the PDB or SourceLink).

It's specially less than useful with async code:

image

The function name and module are correctly extracted but ContextLine is generated code.

@bruno-garcia bruno-garcia requested a review from mitsuhiko June 3, 2019 19:03
@codecov-io
Copy link

codecov-io commented Jun 3, 2019

Codecov Report

Merging #223 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
+ Coverage   88.85%   88.94%   +0.09%     
==========================================
  Files          81       81              
  Lines        2018     2017       -1     
==========================================
+ Hits         1793     1794       +1     
+ Misses        225      223       -2
Impacted Files Coverage Δ
...rc/Sentry/Extensibility/SentryStackTraceFactory.cs 94.93% <ø> (-0.07%) ⬇️
src/Sentry/Internal/BackgroundWorker.cs 95.9% <0%> (+1.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1659126...0216ec7. Read the comment docs.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants