Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adds PublicApiAnalyzers to public projects #234

Merged
merged 3 commits into from
Jun 24, 2019

Conversation

josh-degraw
Copy link
Contributor

RE: #204
Notes:

  • Moved PackageReference for PublicApiAnalyzers into src directory so it only shows for public projects.
  • Turned off warning for RS0017 (Remove deleted types and members from the declared API).
    • Since some properties (specifically SentryOptions.MaxRequestBodySize) are only declared for certain platforms, the warning will show up if it's in the .txt file, and RS0016 (Add public types and members to the declared API) will show up if it's not, and since TreatWarningsAsErrors is enabled, it breaks the build either way.
    • I opted to suppress the first so that things will always be included, but that's a potential bug in the analyzer itself that should be noted.

RS0017 will show errors because some things are only available in some configurations, so I turned that warning off.
@codecov-io
Copy link

codecov-io commented Jun 22, 2019

Codecov Report

Merging #234 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
+ Coverage   88.84%   88.94%   +0.09%     
==========================================
  Files          81       81              
  Lines        2035     2035              
==========================================
+ Hits         1808     1810       +2     
+ Misses        227      225       -2
Impacted Files Coverage Δ
src/Sentry/Internal/BackgroundWorker.cs 95.9% <0%> (+1.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a7b826...70b2d93. Read the comment docs.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for contributing!
Looks good to me, just one comment about the strategy to ignore warnings.

@bruno-garcia
Copy link
Member

:shipit: ! Thanks Josh!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants