Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

null check contextProp.Value during IncludeEventDataOnBreadcrumbs #323

Merged
merged 1 commit into from
Dec 17, 2019

Conversation

markballenger
Copy link
Contributor

without this, our application blows up during logs when properties pass null values (which in some cases is intentional)

@bruno-garcia
Copy link
Member

Thanks for this @markballenger

@bruno-garcia bruno-garcia merged commit 2402423 into getsentry:master Dec 17, 2019
@codecov-io
Copy link

codecov-io commented Dec 17, 2019

Codecov Report

Merging #323 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #323   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files          81       81           
  Lines        2078     2078           
=======================================
  Hits         1917     1917           
  Misses        161      161
Impacted Files Coverage Δ
src/Sentry.NLog/SentryTarget.cs 98.42% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93c77cb...1c07861. Read the comment docs.

@bruno-garcia
Copy link
Member

This fix was released in 2.0.0-beta7. Please give it a try before we release 2.0.0.

@markballenger
Copy link
Contributor Author

Thanks will do

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants