Prevent NullReferenceException in SentryTraceHeader Parsing #3757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Victorvhn
requested review from
bitsandfoxes and
jamescrosswell
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## version-5.0.0 #3757 +/- ##
================================================
Coverage ? 76.54%
================================================
Files ? 381
Lines ? 13997
Branches ? 2818
================================================
Hits ? 10714
Misses ? 2595
Partials ? 688 ☔ View full report in Codecov by Sentry. |
Yeah, I guess it’s because I’m changing the signature of a public method. So the team asked me to open it to v5 instead of main. But I think it will be released soon since v5 will add support for .NET 9 |
jamescrosswell
approved these changes
Nov 17, 2024
There was a problem hiding this comment.
Big thank you for the PR @Victorvhn and for fussing around with the branches. Much appreciated!
Victorvhn
deleted the
fix/prevent-null-reference-sentry-trace-header-parser-on-v5
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey y'all,
I recently encountered an issue where nearly every API request threw an exception after integrating Sentry with OpenTelemetry in my APIs. This issue only affected my environment, likely due to having Just My Code disabled in debugging options.
Upon investigation, I discovered that a null value was being passed to the
Parsemethod inSentryTraceHeader.cs. The method was attempting to call.Split()on this null value, leading to anNullReferenceException.To address this, I added a null check in the
Parsemethod before calling.Split().Please review the changes when you have a chance and let me know if there are any additional adjustments or improvements you’d like to see. Thank you!
Moved from PR