fix: Ensure span ids are 16 characters #3850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamescrosswell
requested changes
Dec 16, 2024
There was a problem hiding this comment.
Thanks for the PR @knd775 ! Looks like a pretty straight forward fix... I just left one comment about preventing a regression.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3850 +/- ##
==========================================
+ Coverage 75.73% 76.53% +0.80%
==========================================
Files 357 389 +32
Lines 13466 14207 +741
Branches 2671 2858 +187
==========================================
+ Hits 10198 10874 +676
- Misses 2593 2640 +47
- Partials 675 693 +18 ☔ View full report in Codecov by Sentry. |
jamescrosswell
approved these changes
Dec 17, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storing span ids as longs causes leading zeroes to be lost. This restores them.