ref: Add span options aliases (WithSpanSampled, WithOpName, WithTransactionName) #624
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up to #611, let's unify the (applicable) span options by prefixing them with "With":
SpanSampled -> WithSpanSampled
OpName -> WithOpName
TransactionName -> WithTransactionName
The original names are deprecated: not removed right away, but there's a task to do it in a version or two: #625
Not touching
ContinueFromRequest
,ContinueFromHeaders
, andContinueFromTrace
since they have slightly different semantics.Why?
Note: some docs will have to be updated after this change is released.