-
-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Use Firebase Test Lab (PoC) #3929
base: main
Are you sure you want to change the base?
Conversation
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6aacee6 | 410.71 ms | 479.32 ms | 68.60 ms |
d983fe1 | 420.68 ms | 425.39 ms | 4.71 ms |
f60000a | 425.20 ms | 495.02 ms | 69.82 ms |
a4e14b9 | 418.86 ms | 435.02 ms | 16.16 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6aacee6 | 1.70 MiB | 2.35 MiB | 669.38 KiB |
d983fe1 | 1.70 MiB | 2.35 MiB | 669.38 KiB |
f60000a | 1.70 MiB | 2.35 MiB | 669.38 KiB |
a4e14b9 | 1.70 MiB | 2.35 MiB | 669.38 KiB |
run: make assembleUiTests | ||
|
||
- name: Install gcloud | ||
uses: 'google-github-actions/setup-gcloud@6189d56e4096ee891640bb02ac264be376592d6a' # pin 2.1.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 🚫 Please pin the action by specifying a commit SHA instead of a tag/branch.
@@ -90,7 +90,7 @@ class AutomaticSpansTest : BaseUiTest() { | |||
// AGP matrix tests have no frames | |||
Assume.assumeTrue(totalFrames > 0) | |||
assertNotEquals(totalFrames, 0) | |||
assertTrue(totalFrames > slowFrames + frozenFrames, "Expected total frames ($totalFrames) to be higher than the sum of slow ($slowFrames) and frozen ($frozenFrames) frames.") | |||
assertTrue(totalFrames >= slowFrames + frozenFrames, "Expected total frames ($totalFrames) to be higher than the sum of slow ($slowFrames) and frozen ($frozenFrames) frames.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assertTrue(totalFrames >= slowFrames + frozenFrames, "Expected total frames ($totalFrames) to be higher than the sum of slow ($slowFrames) and frozen ($frozenFrames) frames.") | |
assertTrue(totalFrames > slowFrames + frozenFrames, "Expected total frames ($totalFrames) to be higher than the sum of slow ($slowFrames) and frozen ($frozenFrames) frames.") |
This test checks there is at least 1 normal frame that is summed to slow + frozen frames. That's why the test should be "long" enough to have at least 1 normal frame even on slower devices
Otherwise total frames is always at least slow + frozen, so it wouldn't make sense to have it, and it could be removed directly
@@ -126,7 +126,7 @@ class AutomaticSpansTest : BaseUiTest() { | |||
// AGP matrix tests have no frames | |||
Assume.assumeTrue(totalFrames > 0) | |||
assertNotEquals(totalFrames, 0) | |||
assertTrue(totalFrames > slowFrames + frozenFrames, "Expected total frames ($totalFrames) to be higher than the sum of slow ($slowFrames) and frozen ($frozenFrames) frames.") | |||
assertTrue(totalFrames >= slowFrames + frozenFrames, "Expected total frames ($totalFrames) to be higher than the sum of slow ($slowFrames) and frozen ($frozenFrames) frames.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
📜 Description
We're frequently running into timeouts on Saucelabs, let's see if Firebase Test Lab is any better.
💡 Motivation and Context
Stable CI
💚 How did you test it?
#skip-changelog
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps