SDKs send queue is no longer shutdown immediately on re-init #4564

adinauer · 2025-07-21T07:18:52Z

📜 Description

SDKs send queue is no longer shutdown immediately on re-init

💡 Motivation and Context

When re-initializing the SDK, we were:

shutting down the queue immediately
no longer allow enqueueing new items
only added the current item in the queue to the offline cache (if available)
discard the other items in the queue

This caused events to be lost in case of re-init, which is common in e.g. Spring Boot + Logback setups.

After the change we are:

no longer allowing new items to be enqueued
items in the queue will be processed until completion

💚 How did you test it?

📝 Checklist

I added tests to verify the changes.
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
I updated the docs if needed.
I updated the wizard if needed.
Review from the native team if needed.
No breaking change or entry added to the changelog.
No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

github-actions · 2025-07-21T07:19:11Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/AsyncHttpTransport.java

github-actions · 2025-07-21T07:24:37Z

	Fails
🚫	Please consider adding a changelog entry for the next release.

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- SDKs send queue is no longer shutdown immediately on re-init ([#4564](https://github.com/getsentry/sentry-java/pull/4564))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 5718733

github-actions · 2025-07-21T07:29:49Z

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	413.65 ms	447.35 ms	33.69 ms
Size	1.58 MiB	2.09 MiB	519.48 KiB

Baseline results on branch: feat/e2e-tests-console-otel

Startup times

Revision	Plain	With Sentry	Diff
`fcbda68`	394.98 ms	421.94 ms	26.96 ms

App size

Revision	Plain	With Sentry	Diff
`fcbda68`	1.58 MiB	2.09 MiB	519.48 KiB

Previous results on branch: feat/sdk-re-init-queue-drain

Startup times

Revision	Plain	With Sentry	Diff
`511b2c9`	456.60 ms	505.83 ms	49.23 ms
`5dff751`	402.70 ms	471.67 ms	68.97 ms

App size

Revision	Plain	With Sentry	Diff
`511b2c9`	1.58 MiB	2.09 MiB	519.47 KiB
`5dff751`	1.58 MiB	2.09 MiB	519.03 KiB

…e-drain

github-actions · 2025-07-21T12:27:21Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/AsyncHttpTransport.java

...sole-opentelemetry-noagent/src/test/kotlin/sentry/systemtest/ConsoleApplicationSystemTest.kt

…c/test/kotlin/sentry/systemtest/ConsoleApplicationSystemTest.kt

github-actions · 2025-07-22T07:36:15Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/AsyncHttpTransport.java

sentry/src/main/java/io/sentry/ShutdownHookIntegration.java

romtsn

LGTM!

…c/test/kotlin/sentry/systemtest/ConsoleApplicationSystemTest.kt

…entry-java into feat/sdk-re-init-queue-drain

…e-drain

github-actions · 2025-07-29T13:50:09Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/AsyncHttpTransport.java

github-actions · 2025-07-29T14:25:23Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/AsyncHttpTransport.java

…e-drain

github-actions · 2025-07-29T14:34:20Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/AsyncHttpTransport.java

* e2e tests for console app * fix test failures by waiting for 10s after first try to find envelopes * add system-test-runner.py script to replace bash scripts for running e2e / system tests * use py script for ci, cleanup, makefile * Format code * remove bash scripts * install requests module * api * fix gh script * Implement E2E tests for OTel based console sample * fixes after merge * Format code * e2e tests for console app * Implement E2E tests for OTel based console sample * fixes after merge * Format code * api * Reduce scope forking when using OpenTelemetry (#4565) * Reduce scope forking in OpenTelemetry * Format code * api * changelog --------- Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io> * SDKs send queue is no longer shutdown immediately on re-init (#4564) * Let queue drain on a restart * Format code * Format code * Update sentry-samples/sentry-samples-console-opentelemetry-noagent/src/test/kotlin/sentry/systemtest/ConsoleApplicationSystemTest.kt * Let queue drain on a restart * Format code * Format code * Update sentry-samples/sentry-samples-console-opentelemetry-noagent/src/test/kotlin/sentry/systemtest/ConsoleApplicationSystemTest.kt * adapt tests * changelog --------- Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io> --------- Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io>

* Do not report cached events as lost * E2E tests for OpenTelemetry based console sample (#4563) * e2e tests for console app * fix test failures by waiting for 10s after first try to find envelopes * add system-test-runner.py script to replace bash scripts for running e2e / system tests * use py script for ci, cleanup, makefile * Format code * remove bash scripts * install requests module * api * fix gh script * Implement E2E tests for OTel based console sample * fixes after merge * Format code * e2e tests for console app * Implement E2E tests for OTel based console sample * fixes after merge * Format code * api * Reduce scope forking when using OpenTelemetry (#4565) * Reduce scope forking in OpenTelemetry * Format code * api * changelog --------- Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io> * SDKs send queue is no longer shutdown immediately on re-init (#4564) * Let queue drain on a restart * Format code * Format code * Update sentry-samples/sentry-samples-console-opentelemetry-noagent/src/test/kotlin/sentry/systemtest/ConsoleApplicationSystemTest.kt * Let queue drain on a restart * Format code * Format code * Update sentry-samples/sentry-samples-console-opentelemetry-noagent/src/test/kotlin/sentry/systemtest/ConsoleApplicationSystemTest.kt * adapt tests * changelog --------- Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io> --------- Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io> * release: 8.18.0 * ref(replay): Use main thread to schedule capture (#4542) * perf(connectivity): Cache network capabilities and status to reduce IPC calls (#4560) * fix(breadcrumbs): Deduplicate battery breadcrumbs (#4561) * fix(ci): remove obsolete NDK debug symbols (#4581) As they don't exist anymore and this is done within sentry-native directly: https://github.com/getsentry/sentry-native/pull/1327/files * fix(android): Remove unused method (#4585) * fix(android): Remove unused method * Update Changelog * Add rules file for documenting SDK offline behaviour (#4572) #skip-changelog ## 📜 Description  Add rules file for documenting SDK offline behaviour ## 💡 Motivation and Context   Should help speed up AI reasoning about the SDK offline/retry behaviour. ## 💚 How did you test it? ## 📝 Checklist  - [ ] I added tests to verify the changes. - [ ] No new PII added or SDK only sends newly added PII if `sendDefaultPII` is enabled. - [ ] I updated the docs if needed. - [ ] I updated the wizard if needed. - [ ] Review from the native team if needed. - [ ] No breaking change or entry added to the changelog. - [ ] No breaking change for hybrid SDKs or communicated to hybrid SDKs. ## 🔮 Next steps * perf(connectivity): Have only one NetworkCallback active at a time (#4562) * fix(scripts): update-gradle script set-version (#4591) * fix: sentry-android-ndk proguard rule keeps all native class (#4427) * fix: sentry-androi-ndk proguard rule keeps all native class * docs: update CHANGELOG * fix: update CHANGELOG * Update CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: Markus Hintersteiner <m.hintersteiner@gmail.com> Co-authored-by: Markus Hintersteiner <markus.hintersteiner@sentry.io> * refactor(lifecycle): Use single lifecycle observer (#4567) * perf(connectivity): Cache network capabilities and status to reduce IPC calls * changelog * Changelog * revert * fix(breadcrumbs): Deduplicate battery breadcrumbs * ref * Changelog * Fix test * perf(connectivity): Have only one NetworkCallback active at a time * Changelog * perf(integrations): Use single lifecycle observer * Add tests * Changelog * Fix tests * Improve callback handling and test visibility (#4593) * Null-check lifecycleObserver --------- Co-authored-by: Markus Hintersteiner <markus.hintersteiner@sentry.io> * fix(sqlite): Fix abstract method error (#4597) * fix(sqlite): Fix abstract method error * Update CHANGELOG.md * Suppress metadata version checks * perf(integrations): Do not register for SystemEvents and NetworkCallbacks when launched with background importance (#4579) * fix(android): Ensure frame metrics listeners are registered/unregistered on the main thread (#4582) * fix(android): Ensure frame metrics listeners are registered/unregistered on the main thread * Fix race conditions * Update Changelog * Update CHANGELOG.md * Address PR feedback * perf(executor): Prewarm SentryExecutorService (#4606) * review feedback * changelog * pass through whether cache stored in AndroidEnvelopeCache + test * Format code --------- Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io> Co-authored-by: getsentry-bot <bot@sentry.io> Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com> Co-authored-by: Markus Hintersteiner <markus.hintersteiner@sentry.io> Co-authored-by: Ghasem Shirdel <shirdelghasem79@gmail.com> Co-authored-by: Markus Hintersteiner <m.hintersteiner@gmail.com>

Let queue drain on a restart

e2de187

adinauer requested review from romtsn, stefanosiano, markushi and lcian as code owners July 21, 2025 07:18

Format code

4ca9d75

Merge branch 'feat/e2e-tests-console-otel' into feat/sdk-re-init-queu…

469e399

…e-drain

Format code

6886aef

adinauer commented Jul 22, 2025

View reviewed changes

...sole-opentelemetry-noagent/src/test/kotlin/sentry/systemtest/ConsoleApplicationSystemTest.kt Outdated Show resolved Hide resolved

Update sentry-samples/sentry-samples-console-opentelemetry-noagent/sr…

7cbb0cc

…c/test/kotlin/sentry/systemtest/ConsoleApplicationSystemTest.kt

romtsn reviewed Jul 28, 2025

View reviewed changes

sentry/src/main/java/io/sentry/ShutdownHookIntegration.java Show resolved Hide resolved

romtsn approved these changes Jul 28, 2025

View reviewed changes

adinauer and others added 6 commits July 29, 2025 15:32

Let queue drain on a restart

a00be80

Format code

ebbbe4c

Format code

abcd734

Update sentry-samples/sentry-samples-console-opentelemetry-noagent/sr…

a5ba264

…c/test/kotlin/sentry/systemtest/ConsoleApplicationSystemTest.kt

Merge branch 'feat/sdk-re-init-queue-drain' of github.com:getsentry/s…

153f14d

…entry-java into feat/sdk-re-init-queue-drain

Merge branch 'feat/e2e-tests-console-otel' into feat/sdk-re-init-queu…

a3988a6

…e-drain

adapt tests

d4b771f

adinauer and others added 2 commits July 29, 2025 16:29

changelog

af99ae7

Merge branch 'feat/e2e-tests-console-otel' into feat/sdk-re-init-queu…

5718733

…e-drain

adinauer merged commit 2e6b3a3 into feat/e2e-tests-console-otel Jul 29, 2025
23 of 24 checks passed

adinauer deleted the feat/sdk-re-init-queue-drain branch July 29, 2025 14:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

SDKs send queue is no longer shutdown immediately on re-init #4564

SDKs send queue is no longer shutdown immediately on re-init #4564

Uh oh!

adinauer commented Jul 21, 2025

Uh oh!

github-actions bot commented Jul 21, 2025

Uh oh!

github-actions bot commented Jul 21, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 21, 2025 •

edited

Loading

Baseline results on branch: feat/e2e-tests-console-otel

Startup times

App size

Previous results on branch: feat/sdk-re-init-queue-drain

Startup times

App size

Uh oh!

github-actions bot commented Jul 21, 2025

Uh oh!

Uh oh!

github-actions bot commented Jul 22, 2025

Uh oh!

Uh oh!

romtsn left a comment •

edited

Loading

Uh oh!

github-actions bot commented Jul 29, 2025

Uh oh!

github-actions bot commented Jul 29, 2025

Uh oh!

Uh oh!

github-actions bot commented Jul 29, 2025

Uh oh!

Uh oh!

Uh oh!

SDKs send queue is no longer shutdown immediately on re-init #4564

SDKs send queue is no longer shutdown immediately on re-init #4564

Uh oh!

Conversation

adinauer commented Jul 21, 2025

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Jul 21, 2025

🚨 Detected changes in high risk code 🚨

Uh oh!

github-actions bot commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Instructions and example for changelog

Uh oh!

github-actions bot commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Performance metrics 🚀

Baseline results on branch: feat/e2e-tests-console-otel

Startup times

App size

Previous results on branch: feat/sdk-re-init-queue-drain

Startup times

App size

Uh oh!

github-actions bot commented Jul 21, 2025

🚨 Detected changes in high risk code 🚨

Uh oh!

Uh oh!

github-actions bot commented Jul 22, 2025

🚨 Detected changes in high risk code 🚨

Uh oh!

Uh oh!

romtsn left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 29, 2025

🚨 Detected changes in high risk code 🚨

Uh oh!

github-actions bot commented Jul 29, 2025

🚨 Detected changes in high risk code 🚨

Uh oh!

Uh oh!

github-actions bot commented Jul 29, 2025

🚨 Detected changes in high risk code 🚨

Uh oh!

Uh oh!

github-actions bot commented Jul 21, 2025 •

edited

Loading

github-actions bot commented Jul 21, 2025 •

edited

Loading

romtsn left a comment •

edited

Loading