fix!: Wrap injected code in block-statement to contain scope #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
previously approved these changes
Jan 7, 2025
That doesn't work with |
timfish
commented
Jan 7, 2025
| @@ -344,7 +346,7 @@ export function generateModuleMetadataInjectorCode(metadata: any) { | |||
| // The checks are to support as many environments as possible. (Node.js, Browser, webworkers, etc.) | |||
| // We are merging the metadata objects in case modules are bundled twice with the plugin | |||
| return `{ | |||
| var _sentryModuleMetadataGlobal = | |||
| const _sentryModuleMetadataGlobal = | |||
There was a problem hiding this comment.
I updated this too because block scoping rules for var mean that it wasn't working as expected
There was a problem hiding this comment.
I am all for this but wondering whether we should cut a major in case somebody uses the bundler plugins for apps in an env where const isn't a thing yet.
There was a problem hiding this comment.
I don't mind which way we go but we should either:
- Use
varand wrap in self-invoking function - Use
varand wrap in try/catch - Use block-statement with
constorlet
timfish
changed the title
lforst
approved these changes
Jan 15, 2025
lforst
changed the title
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Jan 15, 2025
| datasource | package | from | to | | ---------- | ------------------- | ------ | ----- | | npm | @sentry/vite-plugin | 2.23.0 | 3.0.0 | ## [v3.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#300) ##### Breaking Changes - Injected code will now use `let`, which was added in ES6 (ES2015). This means that ES6 is the minimum JavaScript version that the Sentry bundler plugins support. - Deprecated options have been removed: - `deleteFilesAfterUpload` - Use `filesToDeleteAfterUpload` instead - `bundleSizeOptimizations.excludePerformanceMonitoring` - Use `bundleSizeOptimizations.excludeTracing` instead - `_experiments.moduleMetadata` - Use `moduleMetadata` instead - `cleanArtifacts` - Did not do anything ##### List of Changes - fix!: Wrap injected code in block-statement to contain scope ([#646](getsentry/sentry-javascript-bundler-plugins#646)) - chore!: Remove deprecated options ([#654](getsentry/sentry-javascript-bundler-plugins#654)) - feat(logger): Use console methods respective to log level ([#652](getsentry/sentry-javascript-bundler-plugins#652)) - fix(webpack): Ensure process exits when done ([#653](getsentry/sentry-javascript-bundler-plugins#653)) - fix: Use correct replacement matcher for `bundleSizeOptimizations.excludeTracing` ([#644](getsentry/sentry-javascript-bundler-plugins#644)) Work in this release contributed by [@jdelStrother](https://github.com/jdelStrother). Thank you for your contribution!
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Jan 15, 2025
| datasource | package | from | to | | ---------- | ------------------- | ------ | ----- | | npm | @sentry/vite-plugin | 2.23.0 | 3.0.0 | ## [v3.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#300) ##### Breaking Changes - Injected code will now use `let`, which was added in ES6 (ES2015). This means that ES6 is the minimum JavaScript version that the Sentry bundler plugins support. - Deprecated options have been removed: - `deleteFilesAfterUpload` - Use `filesToDeleteAfterUpload` instead - `bundleSizeOptimizations.excludePerformanceMonitoring` - Use `bundleSizeOptimizations.excludeTracing` instead - `_experiments.moduleMetadata` - Use `moduleMetadata` instead - `cleanArtifacts` - Did not do anything ##### List of Changes - fix!: Wrap injected code in block-statement to contain scope ([#646](getsentry/sentry-javascript-bundler-plugins#646)) - chore!: Remove deprecated options ([#654](getsentry/sentry-javascript-bundler-plugins#654)) - feat(logger): Use console methods respective to log level ([#652](getsentry/sentry-javascript-bundler-plugins#652)) - fix(webpack): Ensure process exits when done ([#653](getsentry/sentry-javascript-bundler-plugins#653)) - fix: Use correct replacement matcher for `bundleSizeOptimizations.excludeTracing` ([#644](getsentry/sentry-javascript-bundler-plugins#644)) Work in this release contributed by [@jdelStrother](https://github.com/jdelStrother). Thank you for your contribution!
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Jan 17, 2025
| datasource | package | from | to | | ---------- | ------------------- | ------ | ----- | | npm | @sentry/vite-plugin | 2.23.0 | 3.0.0 | ## [v3.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#300) ##### Breaking Changes - Injected code will now use `let`, which was added in ES6 (ES2015). This means that ES6 is the minimum JavaScript version that the Sentry bundler plugins support. - Deprecated options have been removed: - `deleteFilesAfterUpload` - Use `filesToDeleteAfterUpload` instead - `bundleSizeOptimizations.excludePerformanceMonitoring` - Use `bundleSizeOptimizations.excludeTracing` instead - `_experiments.moduleMetadata` - Use `moduleMetadata` instead - `cleanArtifacts` - Did not do anything ##### List of Changes - fix!: Wrap injected code in block-statement to contain scope ([#646](getsentry/sentry-javascript-bundler-plugins#646)) - chore!: Remove deprecated options ([#654](getsentry/sentry-javascript-bundler-plugins#654)) - feat(logger): Use console methods respective to log level ([#652](getsentry/sentry-javascript-bundler-plugins#652)) - fix(webpack): Ensure process exits when done ([#653](getsentry/sentry-javascript-bundler-plugins#653)) - fix: Use correct replacement matcher for `bundleSizeOptimizations.excludeTracing` ([#644](getsentry/sentry-javascript-bundler-plugins#644)) Work in this release contributed by [@jdelStrother](https://github.com/jdelStrother). Thank you for your contribution!
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_globalcan clash with user code #645