Make arg an options obj for forward compatibility

getsentry · Dec 27, 2024 · a35e2b9 · a35e2b9
1 parent 7f56866
commit a35e2b9
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 5 deletions.
diff --git a/.../browser-integration-tests/suites/integrations/featureFlags/openfeature/errorHook/init.js b/.../browser-integration-tests/suites/integrations/featureFlags/openfeature/errorHook/init.js
@@ -16,7 +16,7 @@ window.openFeatureClient = {
 };
 
 window.Sentry = Sentry;
-window.sentryOpenFeatureIntegration = Sentry.openFeatureIntegration(window.openFeatureClient);
+window.sentryOpenFeatureIntegration = Sentry.openFeatureIntegration({openFeatureClient: window.openFeatureClient});
 
 Sentry.init({
   dsn: 'https://public@dsn.ingest.sentry.io/1337',

diff --git a/dev-packages/browser-integration-tests/suites/integrations/featureFlags/openfeature/init.js b/dev-packages/browser-integration-tests/suites/integrations/featureFlags/openfeature/init.js
@@ -16,7 +16,7 @@ window.openFeatureClient = {
 };
 
 window.Sentry = Sentry;
-window.sentryOpenFeatureIntegration = Sentry.openFeatureIntegration(window.openFeatureClient);
+window.sentryOpenFeatureIntegration = Sentry.openFeatureIntegration({openFeatureClient: window.openFeatureClient});
 
 Sentry.init({
   dsn: 'https://public@dsn.ingest.sentry.io/1337',

diff --git a/packages/browser/src/index.ts b/packages/browser/src/index.ts
@@ -74,4 +74,4 @@ export {
   type FeatureFlagsIntegration,
 } from './integrations/featureFlags';
 export { launchDarklyIntegration, buildLaunchDarklyFlagUsedHandler } from './integrations/featureFlags/launchdarkly';
-export { openFeatureIntegration } from './integrations/featureFlags/openfeature';
+export { openFeatureIntegration, type OpenFeatureIntegrationOptions } from './integrations/featureFlags/openfeature';
diff --git a/packages/browser/src/integrations/featureFlags/openfeature/index.ts b/packages/browser/src/integrations/featureFlags/openfeature/index.ts
@@ -1 +1 @@
-export { openFeatureIntegration } from './integration';
+export { openFeatureIntegration, type OpenFeatureIntegrationOptions } from './integration';
diff --git a/packages/browser/src/integrations/featureFlags/openfeature/integration.ts b/packages/browser/src/integrations/featureFlags/openfeature/integration.ts
@@ -11,7 +11,11 @@ import type { EvaluationDetails, HookContext, HookHints, JsonValue, OpenFeatureC
 import { defineIntegration } from '@sentry/core';
 import { copyFlagsFromScopeToEvent, insertFlagToScope } from '../../../utils/featureFlags';
 
-export const openFeatureIntegration = defineIntegration((openFeatureClient: OpenFeatureClient) => {
+export type OpenFeatureIntegrationOptions = {
+  openFeatureClient: OpenFeatureClient;
+};
+
+export const openFeatureIntegration = defineIntegration(({openFeatureClient}: OpenFeatureIntegrationOptions) => {
   return {
     name: 'OpenFeature',
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		export { openFeatureIntegration } from './integration';
		export { openFeatureIntegration, type OpenFeatureIntegrationOptions } from './integration';