Skip to content

Raven 2.1.0 broke IE8 #498

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
brunis opened this issue Feb 8, 2016 · 2 comments
Closed

Raven 2.1.0 broke IE8 #498

brunis opened this issue Feb 8, 2016 · 2 comments

Comments

@brunis
Copy link

brunis commented Feb 8, 2016

This line:
/(Raven|TraceKit)./.test(normalized['function']) ||
Was changed to:
/(Raven|TraceKit)./.test(normalized.function) ||

and broke IE8 completely

@mattrobenolt
Copy link
Contributor

Hmm, so this was changed as a part of the switch to eslint.

I just ran changed this back to normalized['function'] locally, and eslint now yells at me.

/Users/matt/code/getsentry/raven-js/src/raven.js
  794:39  error  ["function"] is better written in dot notation  dot-notation

@benvinegar thoughts? Or does eslint just not care about IE8?

@mattrobenolt
Copy link
Contributor

Looks like there's this allowedKeywords that defaults to true. :( http://eslint.org/docs/rules/dot-notation#allowkeywords

mattrobenolt added a commit that referenced this issue Feb 8, 2016
eslint by default wanted to change this to .function instead of the
correct ['function'], so this also changes the rule.

Fixes GH-498
benvinegar pushed a commit that referenced this issue Feb 9, 2016
eslint by default wanted to change this to .function instead of the
correct ['function'], so this also changes the rule.

Fixes GH-498
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants