check for both stacktraces before calling 'isSameStacktrace' #1150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve issue #1125
utils.js
to check if both given objects areundefined
. This function will be called fromisSameException
for the Exception interface where stacktrace might be missing.*Note: I've assumed that in such case, where we don't have stacktrace to check, we should return
false
so Raven will report the exception (even in the price of having duplicates)Further more, after investigating issue #1125, I've found the in the function
_processException
, where thestacktrace
object is being built, there isbut no final
else
, which means that in this casestacktrace
resolves toundefined
.I can do some change there, but I don't know what is your exact policy regading such case. So for now I did this extra check, but in my opinion, a proper handling the
stacktrace
object is better.