Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: Add support for SENTRY_SPOTLIGHT env var in Node #13325

Merged
merged 10 commits into from
Aug 13, 2024
Merged

feat: Add support for SENTRY_SPOTLIGHT env var in Node #13325

merged 10 commits into from
Aug 13, 2024

Conversation

BYK
Copy link
Member

@BYK BYK commented Aug 12, 2024 •
edited
Loading

Lms24
Lms24 reviewed Aug 13, 2024
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's just be consistent with env variable values and then this is good to go!

@Lms24
Copy link
Member

Lms24 commented Aug 13, 2024

Also, please update the PR description with the motivation for this change. You and I know it but let's make sure others have the context as well :)

@BYK BYK requested a review from Lms24 August 13, 2024 12:23
Lms24
Lms24 approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests!

@Lms24 Lms24 merged commit 55220cf into getsentry:develop Aug 13, 2024
103 checks passed
@BYK BYK deleted the byk/feat/SENTRY_SPOTLIGHT branch August 13, 2024 15:00
@bagulm123 bagulm123 mentioned this pull request Sep 18, 2024
Open
@onsails onsails mentioned this pull request Sep 18, 2024
Open
@mohamed-helmy22020 mohamed-helmy22020 mentioned this pull request Sep 18, 2024
Open
@gokulk16 gokulk16 mentioned this pull request Sep 23, 2024
Open
@q1blue q1blue mentioned this pull request Sep 24, 2024
Open
This was referenced Sep 24, 2024
Open
Open
@wkylin wkylin mentioned this pull request Sep 25, 2024
Closed
@FengShangWuQi FengShangWuQi mentioned this pull request Sep 27, 2024
Closed
@q1blue q1blue mentioned this pull request Sep 27, 2024
Open
@tristanrobert tristanrobert mentioned this pull request Sep 28, 2024
Merged
@q1blue q1blue mentioned this pull request Sep 30, 2024
Open
@wkylin wkylin mentioned this pull request Oct 1, 2024
Closed
@bagulm123 bagulm123 mentioned this pull request Oct 1, 2024
Open
vjousse pushed a commit to MTES-MCT/ecobalyse that referenced this pull request Oct 1, 2024
@tristanrobert @snyk-bot
chore(Snyk): Upgrade @sentry/browser from 8.27.0 to 8.28.0 (#775)
cea4b83 
![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)


<h3>Snyk has created this PR to upgrade @sentry/browser from 8.27.0 to
8.28.0.</h3>

:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.

<hr/>


- The recommended version is **1 version** ahead of your current
version.

- The recommended version was released on **25 days ago**.



<details>
<summary><b>Release notes</b></summary>
<br/>
  <details>
    <summary>Package name: <b>@sentry/browser</b></summary>
    <ul>
      <li>
<b>8.28.0</b> - <a
href="https://github.com/getsentry/sentry-javascript/releases/tag/8.28.0">2024-09-03</a></br><h3>Important
Changes</h3>
<ul>
<li><strong>Beta release of official NestJS SDK</strong></li>
</ul>
<p>This release contains the beta version of <code>@
sentry/nestjs</code>! For details on how to use it, check out the<br>
<a
href="https://github.com/getsentry/sentry-javascript/blob/master/packages/nestjs/README.md">README</a>.
Any feedback/bug reports<br>
are greatly appreciated, please reach out on GitHub.</p>
<ul>
<li><strong>fix(browser): Remove faulty LCP, FCP and FP normalization
logic (<a class="issue-link js-issue-link" data-error-text="Failed to
load title" data-id="2491960592" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13502"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13502/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13502">#13502</a>)</strong></li>
</ul>
<p>This release fixes a bug in the <code>@ sentry/browser</code> package
and all SDKs depending on this package (e.g. <code>@
sentry/react</code><br>
or <code>@ sentry/nextjs</code>) that caused the SDK to send incorrect
web vital values for the LCP, FCP and FP vitals. The SDK<br>
previously incorrectly processed the original values as they were
reported from the browser. When updating your SDK to<br>
this version, you might experience an increase in LCP, FCP and FP
values, which potentially leads to a decrease in your<br>
performance score in the Web Vitals Insights module in Sentry. This is
because the previously reported values were<br>
smaller than the actually measured values. We apologize for the
inconvenience!</p>
<h3>Other Changes</h3>
<ul>
<li>feat(nestjs): Add <code>SentryGlobalGraphQLFilter</code> (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2498873205" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13545"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13545/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13545">#13545</a>)</li>
<li>feat(nestjs): Automatic instrumentation of nestjs interceptors after
route execution (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2453558373"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13264"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13264/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13264">#13264</a>)</li>
<li>feat(nextjs): Add <code>bundleSizeOptimizations</code> to build
options (<a class="issue-link js-issue-link" data-error-text="Failed to
load title" data-id="2461140938" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13323"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13323/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13323">#13323</a>)</li>
<li>feat(nextjs): Stabilize <code>captureRequestError</code> (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2500682873" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13550"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13550/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13550">#13550</a>)</li>
<li>feat(nuxt): Wrap config in nuxt context (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2486658763" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13457"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13457/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13457">#13457</a>)</li>
<li>feat(profiling): Expose profiler as top level primitive (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2492896219" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13512"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13512/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13512">#13512</a>)</li>
<li>feat(replay): Add layout shift to CLS replay data (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2466359020" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13386"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13386/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13386">#13386</a>)</li>
<li>feat(replay): Upgrade rrweb packages to 2.26.0 (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2489549947" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13483"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13483/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13483">#13483</a>)</li>
<li>fix(cdn): Do not mangle _metadata (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2473467027" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13426"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13426/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13426">#13426</a>)</li>
<li>fix(cdn): Fix SDK source for CDN bundles (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2489085687" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13475"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13475/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13475">#13475</a>)</li>
<li>fix(nestjs): Check arguments before instrumenting with <code>@
Injectable</code> (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2498819596"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13544"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13544/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13544">#13544</a>)</li>
<li>fix(nestjs): Ensure exception and host are correctly passed on when
using @ WithSentry (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2501912092"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13564"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13564/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13564">#13564</a>)</li>
<li>fix(node): Suppress tracing for transport request execution rather
than transport creation (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2491355594"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13491"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13491/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13491">#13491</a>)</li>
<li>fix(replay): Consider more things as DOM mutations for dead clicks
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="2493890628" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13518"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13518/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13518">#13518</a>)</li>
<li>fix(vue): Correctly obtain component name (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2490176912" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13484"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13484/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13484">#13484</a>)</li>
</ul>
<p>Work in this release was contributed by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/leopoldkristjansson/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/leopoldkristjansson">@ leopoldkristjansson</a>,
<a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/mhuggins/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/mhuggins">@ mhuggins</a> and <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/filips123/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/filips123">@ filips123</a>. Thank you for
your<br>
contributions!</p>
      </li>
      <li>
<b>8.27.0</b> - <a
href="https://github.com/getsentry/sentry-javascript/releases/tag/8.27.0">2024-08-27</a></br><h3>Important
Changes</h3>
<ul>
<li>
<p><strong>fix(nestjs): Exception filters in main app module are not
being executed (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2455715839"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13278"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13278/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13278">#13278</a>)</strong></p>
<p>With this release nestjs error monitoring is no longer automatically
set up after adding the <code>SentryModule</code> to your<br>
application, which led to issues in certain scenarios. You will now have
to either add the <code>SentryGlobalFilter</code> to<br>
your main module providers or decorate the <code>catch()</code> method
in your existing global exception filters with the newly<br>
released <code>@ WithSentry()</code> decorator. See the <a
href="https://docs.sentry.io/platforms/javascript/guides/nestjs/"
rel="nofollow">docs</a> for<br>
more details.</p>
</li>
</ul>
<h3>Other Changes</h3>
<ul>
<li>feat: Add options for passing nonces to feedback integration (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2463099308" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13347"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13347/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13347">#13347</a>)</li>
<li>feat: Add support for SENTRY_SPOTLIGHT env var in Node (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2461216903" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13325"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13325/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13325">#13325</a>)</li>
<li>feat(deps): bump @ prisma/instrumentation from 5.17.0 to 5.18.0 (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2461290821" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13327"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13327/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13327">#13327</a>)</li>
<li>feat(feedback): Improve error message for 403 errors (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2476011686" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13441"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13441/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13441">#13441</a>)</li>
<li>fix(deno): Don't rely on <code>Deno.permissions.querySync</code> (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2465617012" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13378"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13378/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13378">#13378</a>)</li>
<li>fix(replay): Ensure we publish replay CDN bundles (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2475611875" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13437"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13437/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13437">#13437</a>)</li>
</ul>
<p>Work in this release was contributed by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/charpeni/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/charpeni">@ charpeni</a>. Thank you for your
contribution!</p>
      </li>
    </ul>
from <a
href="https://github.com/getsentry/sentry-javascript/releases">@sentry/browser
GitHub release notes</a>
  </details>
</details>

---

> [!IMPORTANT]
>
> - Check the changes in this PR to ensure they won't cause issues with
your project.
> - This PR was automatically created by Snyk using the credentials of a
real user.

---

**Note:** _You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs._

**For more information:** <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJkODVjYTllMS0yOGRmLTRmMmQtOWViYi02MmYzMjcwMDQ3OWUiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImQ4NWNhOWUxLTI4ZGYtNGYyZC05ZWJiLTYyZjMyNzAwNDc5ZSJ9fQ=="
width="0" height="0"/>

> - 🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 📜 [Customise PR
templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates)
> - 🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/browser&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)

[//]: #
'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"@sentry/browser","from":"8.27.0","to":"8.28.0"}],"env":"prod","hasFixes":false,"isBreakingChange":false,"isMajorUpgrade":false,"issuesToFix":[],"prId":"d85ca9e1-28df-4f2d-9ebb-62f32700479e","prPublicId":"d85ca9e1-28df-4f2d-9ebb-62f32700479e","packageManager":"npm","priorityScoreList":[],"projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2024-09-03T10:33:13.421Z"},"vulns":[]}'

Co-authored-by: snyk-bot <snyk-bot@snyk.io>
@q1blue q1blue mentioned this pull request Oct 1, 2024
Open
@wkylin wkylin mentioned this pull request Oct 2, 2024
Closed
@KeeghanM KeeghanM mentioned this pull request Oct 3, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BYK @Lms24