feat(browser): Add moduleMetadataIntegration lazy loading support #13817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
|
@gilisho would you mind adding a test that simulates lazy loading the integration? (e.g. in |
|
Sure @chargome, added a test. |
Just FYI, the |
mydea
reviewed
Oct 7, 2024
...ges/browser-integration-tests/suites/integrations/lazyLoad/moduleMetadataIntegration/init.js
Show resolved
Hide resolved
…yLoad/moduleMetadataIntegration/init.js Co-authored-by: Francesco Novy <francesconovy@gmail.com>
mydea
force-pushed
the
modulemetadata-bundle
branch
from
16f43c9 to
a0cc6b5
Compare
mydea
approved these changes
Nov 11, 2024
lforst
pushed a commit
that referenced
this pull request
Nov 11, 2024
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #13817 Co-authored-by: mydea <2411343+mydea@users.noreply.github.com>
mydea
pushed a commit
that referenced
this pull request
Nov 11, 2024
…13822) This PR fixes #13803. The corresponding PR for latest major version is #13817. I saw the bundles generation for integration is happening in `@sentry/integrations`, so I added a corresponding file for `modulemetadata` in this package that exports that integration from `@sentry/core`, so that the bundle actually gets created for this integration as needed.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #13803, and adds support for
moduleMetadataIntegrationto be lazy loaded, in this manner.This integration is crucial for the micro-frontend recommended solution.
Note: I'll also try to create a PR for version ^7.0.