Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(nextjs): Adjust path to requestAsynStorageShim.js template file #13928

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Oct 10, 2024

Looks like we missed adding the build dir to the template path of requestAsyncStorageShim in the NextJS SDK when we changed the package-internal directory structure a while ago (IIRC this was pre-v8 but not sure actually)

I'm a bit surprised that this works at all, given we use exports conditions and this is a path to a specific file not covered by any exports entry. But I guess webpack can handle this still.

EDIT: Well turns out, this doesn't work. We'll need to add the exports entries.

fixes #13925

closes #13926
closes #13927

Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code path is hit when we cannot find the actual request async storage module inside the Next.js package.

We can merge this as-is but the actual fix hides somewhere in #13920

@lforst lforst merged commit 0be3137 into develop Oct 10, 2024
117 of 122 checks passed
@lforst lforst deleted the lms/fix-nextjs-requestAsyncStorageShim-path branch October 10, 2024 07:14
@Lms24
Copy link
Member Author

Lms24 commented Oct 10, 2024

@lforst thx for checking. Just FYI: This fallback still won't work because of the path not being declared in exports. Canary tests still failed.

@lforst
Copy link
Member

lforst commented Oct 10, 2024

@Lms24 ah thanks, I'll get that fixed.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
2 participants