Skip to content

feat(core): Make stream instrumentation opt-in #13951

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 8 commits into from
Oct 11, 2024

Conversation

chargome
Copy link
Member

@chargome chargome commented Oct 11, 2024

This PR adds a new option trackFetchStreamPerformance to the browser tracing integration. Only when set to true, Sentry will instrument streams via fetch.

fixes #13950
related to #13809

@chargome chargome requested review from mydea and lforst October 11, 2024 09:21
Copy link
Contributor

github-actions bot commented Oct 11, 2024

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.73 KB - -
@sentry/browser - with treeshaking flags 21.53 KB - -
@sentry/browser (incl. Tracing) 35.01 KB +0.11% +38 B 🔺
@sentry/browser (incl. Tracing, Replay) 71.68 KB +0.08% +56 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.07 KB +0.08% +45 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 76.01 KB +0.07% +47 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 88.78 KB +0.06% +51 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 90.63 KB +0.05% +41 B 🔺
@sentry/browser (incl. metrics) 27 KB - -
@sentry/browser (incl. Feedback) 39.87 KB - -
@sentry/browser (incl. sendFeedback) 27.38 KB - -
@sentry/browser (incl. FeedbackAsync) 32.17 KB - -
@sentry/react 25.49 KB - -
@sentry/react (incl. Tracing) 37.97 KB +0.09% +32 B 🔺
@sentry/vue 26.91 KB - -
@sentry/vue (incl. Tracing) 36.9 KB +0.1% +35 B 🔺
@sentry/svelte 22.87 KB - -
CDN Bundle 24.05 KB - -
CDN Bundle (incl. Tracing) 36.79 KB +0.09% +31 B 🔺
CDN Bundle (incl. Tracing, Replay) 71.42 KB +0.06% +40 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 76.74 KB +0.06% +41 B 🔺
CDN Bundle - uncompressed 70.53 KB - -
CDN Bundle (incl. Tracing) - uncompressed 109.22 KB +0.17% +183 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 221.58 KB +0.09% +183 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 234.8 KB +0.08% +183 B 🔺
@sentry/nextjs (client) 37.94 KB +0.09% +33 B 🔺
@sentry/sveltekit (client) 35.6 KB +0.11% +40 B 🔺
@sentry/node 124.9 KB +0.01% +2 B 🔺
@sentry/node - without tracing 94.13 KB - -
@sentry/aws-serverless 103.7 KB - -

View base workflow run

Copy link

codecov bot commented Oct 11, 2024

❌ 7 Tests Failed:

Tests completed Failed Passed Skipped
628 7 621 29
View the top 3 failed tests by shortest run time
tracing/trace-lifetime/tracing-without-performance/test.ts outgoing fetch requests have new traceId after navigation
Stack Traces | 0.297s run time
test.ts:99:11 outgoing fetch requests have new traceId after navigation
tracing/request/fetch/test.ts should create spans for fetch requests
Stack Traces | 1.18s run time
test.ts:7:11 should create spans for fetch requests
tracing/request/fetch-relative-url/test.ts should create spans for fetch requests
Stack Traces | 1.23s run time
test.ts:10:11 should create spans for fetch requests

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FLV.js Stream Release Issue with Sentry
2 participants