fix(solidstart): Use production server for e2e tests #14033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a small post-build script to copy over deps that are not correctly resolved in our yarn workspace/pnpm e2e test applications (but do work correctly in standalone projects). This allows us to finally use the vinxi production server to run e2e tests and is similar to what the Nuxt SDK has to do.
chargome
approved these changes
Oct 21, 2024
| "Cleaning the build output should be removed once we can use `vinxi start`." | ||
| ], | ||
| "preview": "pnpm clean:build && HOST=localhost PORT=3030 NODE_OPTIONS='--import ./src/instrument.server.mjs' vinxi dev", | ||
| "start": "HOST=localhost PORT=3030 NODE_OPTIONS='--import ./src/instrument.server.mjs' vinxi start", |
There was a problem hiding this comment.
we don't need the start command anymore?
There was a problem hiding this comment.
I see that the playwright config has pnpm preview as a start command, so this is probably not necessary.
There was a problem hiding this comment.
Yea, what @s1gr1d said. I had the start in there just for local testing but it's not necessary anymore.
s1gr1d
approved these changes
Oct 21, 2024
I wish it would just be the import-in-the-middle hook that was missing, but in my case the solidrouter server file is also missing. I couldn't quite figure out why that was. But yea, happy we can run tests with a production server now, thanks for also looking into this issue and figuring it out for the Nuxt SDK :) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a small post-build script to copy over deps that are not correctly resolved in our yarn workspace/pnpm e2e test applications (but do work correctly in standalone projects). This allows us to finally use the vinxi production server to run e2e tests and is similar to what the Nuxt SDK has to do.
Also allows us to get rid of the double page loads for the first test to avoid hydration errors that were caused by the dev server previously.