Skip to content

fix(nextjs): Don't leak webpack types into exports #14116

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Oct 29, 2024

Fixes #14066

We're just vendoring the types. The chance that anyone is depending on the specifics is lim x -> 0.

Copy link
Contributor

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 22.73 KB - -
@sentry/browser - with treeshaking flags 21.52 KB - -
@sentry/browser (incl. Tracing) 35.11 KB - -
@sentry/browser (incl. Tracing, Replay) 71.79 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.25 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 76.12 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 88.93 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 90.76 KB - -
@sentry/browser (incl. metrics) 26.98 KB - -
@sentry/browser (incl. Feedback) 39.87 KB - -
@sentry/browser (incl. sendFeedback) 27.37 KB - -
@sentry/browser (incl. FeedbackAsync) 32.17 KB - -
@sentry/react 25.48 KB - -
@sentry/react (incl. Tracing) 38.07 KB - -
@sentry/vue 26.87 KB - -
@sentry/vue (incl. Tracing) 36.99 KB - -
@sentry/svelte 22.86 KB - -
CDN Bundle 24.08 KB - -
CDN Bundle (incl. Tracing) 36.92 KB - -
CDN Bundle (incl. Tracing, Replay) 71.58 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 76.91 KB - -
CDN Bundle - uncompressed 70.62 KB - -
CDN Bundle (incl. Tracing) - uncompressed 109.61 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 222.04 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 235.25 KB - -
@sentry/nextjs (client) 38.15 KB - -
@sentry/sveltekit (client) 35.71 KB - -
@sentry/node 129.6 KB +0.24% +317 B 🔺
@sentry/node - without tracing 94.3 KB +0.31% +291 B 🔺
@sentry/aws-serverless 105.17 KB +0.26% +270 B 🔺

View base workflow run

Copy link

codecov bot commented Oct 29, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
233 1 232 10
View the top 1 failed tests by shortest run time
client-app-routing-instrumentation.test.ts Creates a navigation transaction for app router routes
Stack Traces | 30s run time
client-app-routing-instrumentation.test.ts:19:5 Creates a navigation transaction for app router routes

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for fixing!

@lforst lforst merged commit 57ba5a7 into develop Oct 29, 2024
126 checks passed
@lforst lforst deleted the lforst-dont-leak-types-nextjs branch October 29, 2024 12:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
3 participants