Skip to content

feat(core): Add trpc path to context in trpcMiddleware #14218

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

phuctm97
Copy link
Contributor

Resolves #14158

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, would you mind adding a test for that?

If you search the codebase for procedure_type it will guide you to the correct e2e tests (nextjs-t3 and node-express )

@lforst lforst changed the title Add trpc path to context in trpcMiddleware feat(core): Add trpc path to context in trpcMiddleware Nov 11, 2024
@lforst
Copy link
Contributor

lforst commented Nov 11, 2024

Hi, while looking at this PR I noticed that we were bleeding data between trpc handlers which may become a very obvious issue when using things like the batch link.

I updated this PR to have proper scoping and added the checks @chargome asked for.

@lforst lforst requested a review from chargome November 11, 2024 09:02
@chargome chargome removed their assignment Nov 11, 2024
@lforst lforst merged commit a579fba into getsentry:develop Nov 11, 2024
131 checks passed
lforst added a commit that referenced this pull request Nov 11, 2024
This PR adds the external contributor to the CHANGELOG.md file, so that
they are credited for their contribution. See #14218

Co-authored-by: lforst <8118419+lforst@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add trpc path to context in trpcMiddleware
3 participants