Skip to content

feat(utils): Deprecate memoBuilder, BAGGAGE_HEADER_NAME, and makeFifoCache #14434

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2024
Merged

feat(utils): Deprecate memoBuilder, BAGGAGE_HEADER_NAME, and makeFifoCache #14434

merged 1 commit into from
Nov 25, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Nov 22, 2024 •
edited
Loading

Ref #14267

Deprecates a few unused/unnecessary exports from the utils package.

@lforst lforst mentioned this pull request Nov 22, 2024
Closed
13 tasks
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.87 KB - -
@sentry/browser - with treeshaking flags 21.56 KB - -
@sentry/browser (incl. Tracing) 35.45 KB -0.01% -2 B 🔽
@sentry/browser (incl. Tracing, Replay) 72.25 KB +0.02% +10 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.51 KB -0.03% -17 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 76.54 KB -0.01% -4 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 88.98 KB -0.03% -20 B 🔽
@sentry/browser (incl. Feedback) 39.62 KB - -
@sentry/browser (incl. sendFeedback) 27.5 KB - -
@sentry/browser (incl. FeedbackAsync) 32.3 KB - -
@sentry/react 25.58 KB - -
@sentry/react (incl. Tracing) 38.33 KB +0.03% +11 B 🔺
@sentry/vue 27.03 KB - -
@sentry/vue (incl. Tracing) 37.28 KB -0.02% -6 B 🔽
@sentry/svelte 23.02 KB - -
CDN Bundle 24.04 KB - -
CDN Bundle (incl. Tracing) 37.03 KB +0.04% +14 B 🔺
CDN Bundle (incl. Tracing, Replay) 71.77 KB -0.06% -38 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 77.13 KB -0.04% -26 B 🔽
CDN Bundle - uncompressed 70.85 KB - -
CDN Bundle (incl. Tracing) - uncompressed 110.23 KB +0.03% +29 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 223.03 KB +0.02% +29 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 236.24 KB +0.02% +29 B 🔺
@sentry/nextjs (client) 38.42 KB -0.01% -2 B 🔽
@sentry/sveltekit (client) 35.96 KB +0.02% +5 B 🔺
@sentry/node 134.47 KB - -
@sentry/node - without tracing 96.3 KB - -
@sentry/aws-serverless 106.56 KB - -

View base workflow run

@lforst lforst merged commit 8d1dbb1 into develop Nov 25, 2024
155 of 156 checks passed
@lforst lforst deleted the lforst-depr-bunchastuff branch November 25, 2024 09:43
@antonis antonis mentioned this pull request Dec 9, 2024
Merged
10 tasks
This was referenced Dec 18, 2024
Merged
Merged
AbhiPrasad added a commit that referenced this pull request Dec 18, 2024
@AbhiPrasad
feat(core)!: Remove makeFifoCache method (#14786)
6245d22 
ref: #14268

Deprecation PR:
#14434

Removes `makeFifoCache`. This has no replacement.
AbhiPrasad added a commit that referenced this pull request Dec 18, 2024
@AbhiPrasad
feat(core)!: Remove BAGGAGE_HEADER_NAME export (#14785)
6d006bf 
ref: #14268

Deprecation PR:
#14434

Removes `BAGGAGE_HEADER_NAME`. Use `"baggage"` string constant directly instead.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@chargome chargome chargome approved these changes

@mydea mydea Awaiting requested review from mydea

@andreiborza andreiborza Awaiting requested review from andreiborza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lforst @chargome