Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(v8/replay): Disable mousemove sampling in rrweb for iOS browsers #14944

Merged
merged 4 commits into from
Jan 10, 2025
Merged

fix(v8/replay): Disable mousemove sampling in rrweb for iOS browsers #14944

merged 4 commits into from
Jan 10, 2025
+83 −2

Conversation

chargome
Copy link
Member

@chargome chargome commented Jan 8, 2025

backports #14937

ref #14534

@chargome
fix(replay): Disable mousemove sampling in rrweb for iOS browsers (#1…
fa54a0f 
…4937)

This PR updates the rrweb sampling options depending on the userAgent as
this tends to block the main thread on iOS browsers.

closes #14534
@chargome chargome self-assigned this Jan 8, 2025
@chargome chargome requested a review from a team as a code owner January 8, 2025 17:57
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025 •
edited
Loading

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.29 KB - -
@sentry/browser - with treeshaking flags 21.96 KB - -
@sentry/browser (incl. Tracing) 35.85 KB - -
@sentry/browser (incl. Tracing, Replay) 73.19 KB +0.14% +100 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.58 KB +0.16% +99 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 77.5 KB +0.14% +108 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 89.44 KB +0.12% +102 B 🔺
@sentry/browser (incl. Feedback) 39.5 KB - -
@sentry/browser (incl. sendFeedback) 27.89 KB - -
@sentry/browser (incl. FeedbackAsync) 32.69 KB - -
@sentry/react 25.96 KB - -
@sentry/react (incl. Tracing) 38.66 KB - -
@sentry/vue 27.57 KB - -
@sentry/vue (incl. Tracing) 37.71 KB - -
@sentry/svelte 23.45 KB - -
CDN Bundle 24.49 KB - -
CDN Bundle (incl. Tracing) 37.56 KB - -
CDN Bundle (incl. Tracing, Replay) 72.84 KB +0.13% +94 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 78.2 KB +0.13% +97 B 🔺
CDN Bundle - uncompressed 71.93 KB - -
CDN Bundle (incl. Tracing) - uncompressed 111.42 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 225.68 KB +0.09% +185 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 238.78 KB +0.08% +185 B 🔺
@sentry/nextjs (client) 38.92 KB - -
@sentry/sveltekit (client) 36.36 KB - -
@sentry/node 162.8 KB - -
@sentry/node - without tracing 98.94 KB -0.01% -2 B 🔽
@sentry/aws-serverless 126.63 KB - -

View base workflow run

@chargome chargome merged commit 0c3b2a4 into v8 Jan 10, 2025
156 checks passed
@chargome chargome deleted the cg/v8-backport-replay-ios-mousemove branch January 10, 2025 13:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@c298lee c298lee c298lee approved these changes

Assignees

@chargome chargome

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chargome @c298lee