Skip to content

feat(react)!: Raise minimum supported TanStack Router version to 1.63.0 #15030

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2025
Merged

feat(react)!: Raise minimum supported TanStack Router version to 1.63.0 #15030

merged 1 commit into from
Jan 16, 2025

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Jan 16, 2025

Ref #14263

@lforst lforst mentioned this pull request Jan 16, 2025
Closed
4 tasks
@lforst lforst marked this pull request as ready for review January 16, 2025 09:54
Lms24
Lms24 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! idea: should we declare an optional peer dependency in the react SDK?

@lforst
Copy link
Contributor Author

lforst commented Jan 16, 2025

LGTM! idea: should we declare an optional peer dependency in the react SDK?

@Lms24 I thought about it but I am a bit scared to do so because I don't know how well peerDependenciesMeta is supported in all the package managers. The react package is pretty popular and we also don't do it for redux or anything so I would leave it for now. As soon as we get a report with people being confused, we can consider again though.

@lforst lforst merged commit ea830c1 into develop Jan 16, 2025
143 checks passed
@lforst lforst deleted the lforst-tanstack-router-min-v branch January 16, 2025 10:37
@Lms24
Copy link
Member

Lms24 commented Jan 16, 2025

sounds good to me! thx!

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lforst @Lms24