Skip to content

ci: Update labels for remix integration tests #15076

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Jan 20, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -747,7 +747,7 @@ jobs:
run: yarn test

job_remix_integration_tests:
name: Remix v${{ matrix.remix }} (Node ${{ matrix.node }}) Tests
name: Remix (Node ${{ matrix.node }}) Tests
needs: [job_get_metadata, job_build]
if: needs.job_build.outputs.changed_remix == 'true' || github.event_name != 'pull_request'
runs-on: ubuntu-20.04
Expand Down
7 changes: 1 addition & 6 deletions packages/remix/src/index.client.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,7 @@ export * from '@sentry/react';
// function signature is the same as in the server SDK.
// See issue: https://github.com/getsentry/sentry-javascript/issues/9594
/* eslint-disable @typescript-eslint/no-unused-vars */
export async function captureRemixServerException(
err: unknown,
name: string,
request: Request,
isRemixV2?: boolean,
): Promise<void> {
export async function captureRemixServerException(err: unknown, name: string, request: Request): Promise<void> {
DEBUG_BUILD &&
logger.warn(
'`captureRemixServerException` is a server-only function and should not be called in the browser. ' +
Expand Down
7 changes: 1 addition & 6 deletions packages/remix/src/index.types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,7 @@ export declare const contextLinesIntegration: typeof clientSdk.contextLinesInteg
export declare const getDefaultIntegrations: (options: Options) => Integration[];
export declare const defaultStackParser: StackParser;

export declare function captureRemixServerException(
err: unknown,
name: string,
request: Request,
isRemixV2?: boolean,
): Promise<void>;
export declare function captureRemixServerException(err: unknown, name: string, request: Request): Promise<void>;

// This variable is not a runtime variable but just a type to tell typescript that the methods below can either come
// from the client SDK or from the server SDK. TypeScript is smart enough to understand that these resolve to the same
Expand Down
Loading