-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
ref(core)!: Move shutdownTimeout
option type from core to node
#15217
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
We used to have `shutdownTimeout` in the core client options, but this option only applies in node, so we can move it there. Also fixing a small unnecessary check I noticed along the way.
ce91ea3
to
3709fff
Compare
Lms24
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Technically this is breaking, so let's add a !
in the PR title/commit msg
shutdownTimeout
option type from core to node
shutdownTimeout
option type from core to nodeshutdownTimeout
option type from core to node
antonis
added a commit
to getsentry/sentry-react-native
that referenced
this pull request
Feb 19, 2025
10 tasks
12 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to have
shutdownTimeout
in the core client options, but this option only applies in node, so we can move it there. Also fixing a small unnecessary check I noticed along the way.This is technically breaking, but should not affect anybody as this option is not used (and documented) anywhere outside of node.