Skip to content

fix(react): From location can be undefined in Tanstack Router Instrumentation #15235

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2025
Merged

fix(react): From location can be undefined in Tanstack Router Instrumentation #15235

merged 1 commit into from
Jan 30, 2025

Conversation

tannerlinsley
Copy link
Contributor

@tannerlinsley tannerlinsley commented Jan 30, 2025 •
edited by TkDodo
Loading

fixes #15234

Due to a big bug in TanStack Router getting fixed, this needs an optional chain to not die.

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

@tannerlinsley
fix: from location can be undefined
24e14a7 
Due to a big bug in TanStack Router getting fixed, this needs an optional chain to not die.
@TkDodo TkDodo mentioned this pull request Jan 30, 2025
Closed
Lms24
Lms24 approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Lms24 Lms24 changed the title fix: from location can be undefined fix(react): From location can be undefined in Tanstack Router Instrumentation Jan 30, 2025
@Lms24 Lms24 merged commit 0f25452 into getsentry:develop Jan 30, 2025
60 checks passed
@HazAT HazAT mentioned this pull request Jan 30, 2025
Merged
Lms24 pushed a commit that referenced this pull request Jan 30, 2025
@tannerlinsley @Lms24
fix(react): From location can be undefined in Tanstack Router Instrum…
0a9c4d0 
…entation (#15235)

fixes #15234

Due to a big bug in TanStack Router getting fixed, this needs an
optional chain to not die.
@Lms24 Lms24 mentioned this pull request Jan 30, 2025
Merged
Lms24 pushed a commit that referenced this pull request Jan 31, 2025
@tannerlinsley @Lms24
fix(react): From location can be undefined in Tanstack Router Instrum…
09a3f36 
…entation (#15235)

fixes #15234

Due to a big bug in TanStack Router getting fixed, this needs an
optional chain to not die.
Lms24 added a commit that referenced this pull request Jan 31, 2025
@HazAT @Lms24
chore: Add external contributor to CHANGELOG.md (#15236)
e3ee276 
This PR adds the external contributor to the CHANGELOG.md file, so that
they are credited for their contribution. See #15235

---------

Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
@mydea mydea mentioned this pull request Jan 31, 2025
Merged
mydea added a commit that referenced this pull request Jan 31, 2025
@mydea
ref(react): Adapt tanstack router type (#15241)
829d4da 
We adapted this here but did not adapt the types:
#15235
Lms24 added a commit that referenced this pull request Jan 31, 2025
@Lms24 @tannerlinsley @mydea
fix(v8/react): From location can be undefined in Tanstack Router Inst…
ef4f210 
…rumentation (#15237)

backport of #15235 and #15241

---------

Co-authored-by: Tanner Linsley <tannerlinsley@gmail.com>
Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@TkDodo TkDodo TkDodo approved these changes

@Lms24 Lms24 Lms24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Browser Tracing causing TanStack Router to be stuck in pending state after v1.98.3
3 participants
@tannerlinsley @TkDodo @Lms24