feat(core): Add inheritOrSampleWith helper to traceSampler
#15277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
reviewed
Feb 4, 2025
| sampleRate = options.tracesSampler(samplingContext); | ||
| sampleRate = options.tracesSampler({ | ||
| ...samplingContext, | ||
| inheritOrSampleWith(fallbackSampleRate) { |
There was a problem hiding this comment.
Suggested change
| inheritOrSampleWith(fallbackSampleRate) { | |
| inheritOrSampleWith: (fallbackSampleRate) => { |
is this maybe slightly cleaner regarding this context? 🤔
mydea
reviewed
Feb 4, 2025
|
|
||
| // Fallback if parent sample rate is not on the incoming trace (e.g. if there is no baggage) | ||
| if (typeof samplingContext.parentSampled === 'boolean') { | ||
| return 1; |
There was a problem hiding this comment.
Suggested change
| return 1; | |
| return Number(samplingContext.parentSampled); |
!! otherwise this would propagate 1 for false :D
size-limit report 📦
|
|
Should we backport this? 🤔 I think it may be worth it, makes docs much easier in that regard..? |
Zen-cronic
pushed a commit
to Zen-cronic/sentry-javascript
that referenced
this pull request
Feb 5, 2025
10 tasks
12 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found in getsentry/sentry-docs#12544 that the proposed ux is horrible because nobody would understand what it does, so we're adding a helper that facilitates inheriting a sampling decision that also allows for catching more edge-cases without worsening ux and is self explanatory in what it does.