Skip to content

fix(solidstart): Do not copy release-injection map file #15302

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Feb 5, 2025

fixes #15291

@s1gr1d s1gr1d requested a review from andreiborza February 5, 2025 10:34
Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is this not a problem in the Nuxt SDK too?

@s1gr1d
Copy link
Member Author

s1gr1d commented Feb 5, 2025

is this not a problem in the Nuxt SDK too?

No, as the file is included by adding a Nuxt plugin template (here) and then it picks up the file.

@s1gr1d s1gr1d merged commit bef2b38 into develop Feb 5, 2025
35 checks passed
@s1gr1d s1gr1d deleted the sig/solidstart-injection-file branch February 5, 2025 11:48
s1gr1d added a commit that referenced this pull request Feb 10, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

withSentry does not copy or generate _sentry-release-injection-file-*.js. Sometimes only copies .js.map file!
2 participants