feat(core): Create types and utilities for span links #15375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1gr1d
force-pushed
the
sig/span-link-types
branch
from
acfbac3 to
10337a5
Compare
Lms24
reviewed
Feb 12, 2025
packages/core/src/utils/spanUtils.ts
Outdated
| /** | ||
| * Converts the span links array to a flattened version to be sent within an envelope | ||
| */ | ||
| export function convertSpanLinksForEnvelope(links: SpanLink[]): SpanLinkJSON[] { |
There was a problem hiding this comment.
q: I assume this is getting tested in subsequent PRs when we serialize envelopes? If so, ignore me and no objections :)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the base for adding span links to the SDK. Those types will be used both our OTel and Core SDK.