Skip to content

feat(core): Allow for nested trpc context #15379

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 12, 2025
Merged

feat(core): Allow for nested trpc context #15379

merged 2 commits into from
Feb 12, 2025

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Feb 12, 2025

@lforst lforst requested a review from chargome February 12, 2025 10:10
chargome
chargome approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I guess just setting a default for normalizeDepth would cause too many large payloads?

@lforst
Copy link
Contributor Author

lforst commented Feb 12, 2025

Looks good, I guess just setting a default for normalizeDepth would cause too many large payloads?

Yeah the option is a bit sucky because it defines normalization depth from the root of the payload which is by default 1 layer deep for context.

@lforst lforst merged commit 3d16a07 into develop Feb 12, 2025
148 checks passed
@lforst lforst deleted the lforst-nested-trpc-context branch February 12, 2025 12:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@chargome chargome chargome approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lforst @chargome