Skip to content

feat(node): Support Express v5 #15380

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 6 commits into from
Feb 20, 2025
Merged

feat(node): Support Express v5 #15380

merged 6 commits into from
Feb 20, 2025

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Feb 12, 2025

The goal is for Express to eventually support publishing events to diagnostics_channel (#15107) so that Open Telemetry can instrument it without monkey-patching internal code. However, this might take a while and it would be great to support Express v5 now. This PR is a stop-gap solution until that work is complete and published.

This PR vendors the code added in my otel PR:

@lforst lforst self-requested a review February 12, 2025 10:23
Copy link

codecov bot commented Feb 12, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
1527 1 1526 18
View the top 1 failed test(s) by shortest run time
test/integration/test/client/root-loader.test.ts should return redirect to an external path with no baggage and trace injected.
Stack Traces | 4.11s run time
root-loader.test.ts:165:1 should return redirect to an external path with no baggage and trace injected.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link
Contributor

github-actions bot commented Feb 12, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.95 KB - -
@sentry/browser - with treeshaking flags 22.73 KB - -
@sentry/browser (incl. Tracing) 35.89 KB - -
@sentry/browser (incl. Tracing, Replay) 72.88 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 66.39 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 77.13 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 90.09 KB - -
@sentry/browser (incl. Feedback) 40.1 KB - -
@sentry/browser (incl. sendFeedback) 27.58 KB - -
@sentry/browser (incl. FeedbackAsync) 32.38 KB - -
@sentry/react 24.78 KB - -
@sentry/react (incl. Tracing) 37.78 KB - -
@sentry/vue 27.14 KB - -
@sentry/vue (incl. Tracing) 37.6 KB - -
@sentry/svelte 22.99 KB - -
CDN Bundle 24.17 KB - -
CDN Bundle (incl. Tracing) 35.93 KB - -
CDN Bundle (incl. Tracing, Replay) 70.75 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 75.91 KB - -
CDN Bundle - uncompressed 70.64 KB - -
CDN Bundle (incl. Tracing) - uncompressed 106.74 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 217.95 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 230.52 KB - -
@sentry/nextjs (client) 38.76 KB - -
@sentry/sveltekit (client) 36.32 KB - -
@sentry/node 129.13 KB +1.2% +1.52 KB 🔺
@sentry/node - without tracing 97.9 KB - -
@sentry/aws-serverless 107.34 KB -0.01% -1 B 🔽

View base workflow run

@timfish timfish marked this pull request as ready for review February 12, 2025 21:30
@timfish timfish requested a review from chargome February 13, 2025 11:06
@AbhiPrasad AbhiPrasad merged commit 1aa5bbe into develop Feb 20, 2025
129 checks passed
@AbhiPrasad AbhiPrasad deleted the timfish/feat/express-v5 branch February 20, 2025 16:50
@github-actions github-actions bot mentioned this pull request Feb 24, 2025
@Burgov
Copy link

Burgov commented Apr 4, 2025

Should the documentation be updated? https://docs.sentry.io/platforms/javascript/guides/express/ still mentions limited support

@AbhiPrasad
Copy link
Member

@Burgov good catch! I made a PR to fix this in the docs: getsentry/sentry-docs#13240

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Express v5
3 participants