Skip to content

perf(node): Store normalized request for processing #15570

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Mar 4, 2025

This should help reduce the memory pressure of the SDK as we don't store
the entire request in memory anymore.

resolves #15528

This should help reduce the memory pressure of the SDK as we don't store
the entire request in memory anymore.
@AbhiPrasad AbhiPrasad requested a review from a team March 4, 2025 13:39
@AbhiPrasad AbhiPrasad self-assigned this Mar 4, 2025
@AbhiPrasad AbhiPrasad requested review from lforst and Lms24 and removed request for a team March 4, 2025 13:39
@AbhiPrasad AbhiPrasad changed the title pref(node): Store normalized request for processing perf(node): Store normalized request for processing Mar 4, 2025
@AbhiPrasad
Copy link
Member Author

Looks like the express e2e test is failing, but I can't reproduce this locally

 Polling for error eventId: 7f78d75287254a28acbf303f0893379b
  ✓  2 [chromium] › tests/send-to-sentry.test.ts:28:5 › Sends transaction to Sentry (4.0s)
  ✘  1 [chromium] › tests/send-to-sentry.test.ts:9:5 › Sends exception to Sentry (1.5m)


  1) [chromium] › tests/send-to-sentry.test.ts:9:5 › Sends exception to Sentry ─────────────────────

    Error: expect(received).toBe(expected) // Object.is equality

    Expected: 200
    Received: 404

    Call Log:
    - Timeout 90000ms exceeded while waiting on the predicate

      15 |   console.log(`Polling for error eventId: ${exceptionId}`);
      16 |
    > 17 |   await expect
         |   ^
      18 |     .poll(
      19 |       async () => {
      20 |         const response = await fetch(url, { headers: { Authorization: `*** } });
        at /home/runner/work/sentry-javascript/sentry-javascript/dev-packages/e2e-tests/test-applications/node-express-send-to-sentry/tests/send-to-sentry.test.ts:17:3

@AbhiPrasad
Copy link
Member Author

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) March 4, 2025 16:45
@AbhiPrasad AbhiPrasad merged commit 748c5ce into develop Mar 4, 2025
102 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-express-normalized-request branch March 4, 2025 16:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak for Express requests with large attached objects
2 participants