Skip to content

Add cloudflare adapter detection and path generation #15603

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Mar 6, 2025

Conversation

rileyg98
Copy link
Contributor

@rileyg98 rileyg98 commented Mar 6, 2025

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

This PR expands upon #14672 by adding detection of the @sveltejs/adapter-cloudflare adapter and defining it's output directory (cloudflare as opposed to output). I've tested it with a Cloudflare Pages project and it was successful in building and uploading sourcemaps, whereas relying on 'other' caused an infinite loop and an OOM when trying to upload sourcemaps.

@s1gr1d s1gr1d requested a review from Lms24 March 6, 2025 11:36
Copy link
Member

@s1gr1d s1gr1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this PR :)

@s1gr1d s1gr1d merged commit e3692a4 into getsentry:develop Mar 6, 2025
32 checks passed
AbhiPrasad added a commit that referenced this pull request Mar 6, 2025
This PR adds the external contributor to the CHANGELOG.md file, so that
they are credited for their contribution. See #15603

---------

Co-authored-by: s1gr1d <32902192+s1gr1d@users.noreply.github.com>
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants