feat(node): Do not add HTTP & fetch span instrumentation if tracing is disabled #15730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chargome
approved these changes
Mar 19, 2025
mydea
added a commit
that referenced
this pull request
Mar 19, 2025
…ntation (#15732) Part of #15730 Noticed that this is not really happening otherwise, so if we are not adding the `HttpInstrumentation` we now make sure to extract incoming traces ourselves! This will unlock us not adding that instrumentation when tracing is disabled. Also includes #15731 as a side effect.
mydea
force-pushed
the
fn/skip-http-spans-without-performance
branch
from
259f829 to
34f5b2a
Compare
size-limit report 📦
|
mydea
force-pushed
the
fn/skip-http-spans-without-performance
branch
from
34f5b2a to
f6f52ff
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #15725, this PR stops adding the
HttpInstrumentation/UndiciInstrumentationif tracing is not enabled.I think this should not really be breaking, as the integrations should not do anything else, if tracing is disabled 🤔
This only skips the http instrumentation without spans on node 22+, as only there our own diagnostics-channel based instrumentation can cover everything we need.