Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: Don't truncate error messages #15818

Merged
merged 4 commits into from
Mar 31, 2025
Merged

feat: Don't truncate error messages #15818

merged 4 commits into from
Mar 31, 2025

Conversation

lforst
Copy link
Member

@lforst lforst commented Mar 25, 2025 •
edited
Loading

Ref https://github.com/getsentry/projects/issues/837 for for not truncating error messages and letting relay do that.

Kinda undoes #8593

Should be merged after #15819 because otherwise, we keep humongous strings in memory.

@lforst lforst self-assigned this Mar 25, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 25, 2025 •
edited
Loading

size-limit report 📦

Path Size % Change Change
@sentry/browser 23 KB -0.34% -78 B 🔽
@sentry/browser - with treeshaking flags 22.79 KB -0.38% -88 B 🔽
@sentry/browser (incl. Tracing) 36.41 KB -0.22% -81 B 🔽
@sentry/browser (incl. Tracing, Replay) 73.58 KB -0.1% -71 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 66.93 KB -0.1% -68 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 78.23 KB -0.09% -70 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 90.79 KB -0.09% -78 B 🔽
@sentry/browser (incl. Feedback) 40.13 KB -0.2% -79 B 🔽
@sentry/browser (incl. sendFeedback) 27.64 KB -0.27% -74 B 🔽
@sentry/browser (incl. FeedbackAsync) 32.43 KB -0.23% -74 B 🔽
@sentry/react 24.79 KB -0.3% -76 B 🔽
@sentry/react (incl. Tracing) 38.31 KB -0.21% -81 B 🔽
@sentry/vue 27.22 KB -0.28% -77 B 🔽
@sentry/vue (incl. Tracing) 38.11 KB -0.19% -73 B 🔽
@sentry/svelte 23.04 KB -0.32% -75 B 🔽
CDN Bundle 24.25 KB -0.35% -86 B 🔽
CDN Bundle (incl. Tracing) 36.44 KB -0.2% -74 B 🔽
CDN Bundle (incl. Tracing, Replay) 71.46 KB -0.1% -70 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 76.63 KB -0.1% -78 B 🔽
CDN Bundle - uncompressed 70.73 KB -0.28% -201 B 🔽
CDN Bundle (incl. Tracing) - uncompressed 107.91 KB -0.19% -204 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed 219.2 KB -0.1% -204 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 231.77 KB -0.09% -204 B 🔽
@sentry/nextjs (client) 39.6 KB -0.2% -79 B 🔽
@sentry/sveltekit (client) 36.85 KB -0.19% -71 B 🔽
@sentry/node 142.84 KB -0.05% -66 B 🔽
@sentry/node - without tracing 96.04 KB -0.08% -70 B 🔽
@sentry/aws-serverless 120.39 KB -0.06% -64 B 🔽

View base workflow run

@lforst lforst mentioned this pull request Mar 25, 2025
Merged
lforst added a commit that referenced this pull request Mar 26, 2025
@lforst
feat: Always truncate stored breadcrumb messages to 2kb (#15819)
7191ebd 
We had this logic in the console instrumentation before but it probably
makes sense to truncate all breadcrumbs to some degree for memory
consumption reasons.

Acts as prework for
#15818 because if we
don't truncate error messages they will end up as very big strings in
breadcrumbs.
@lforst lforst marked this pull request as ready for review March 28, 2025 08:57
@lforst lforst requested review from mydea, cleptric and Lms24 March 28, 2025 08:57
Lms24
Lms24 approved these changes Mar 31, 2025
View reviewed changes
...ackages/browser-integration-tests/suites/public-api/captureException/linkedErrors/subject.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't resist

image

@lforst lforst merged commit 147989b into develop Mar 31, 2025
156 of 157 checks passed
@lforst lforst deleted the lforst-truncation-logic branch March 31, 2025 15:05
onurtemizkan pushed a commit that referenced this pull request Apr 3, 2025
@lforst @onurtemizkan
feat: Don't truncate error messages (#15818)
a6d2b06 
Ref https://github.com/getsentry/projects/issues/837 for for not
truncating error messages and letting relay do that.

Kinda undoes #8593

Should be merged after
#15819 because
otherwise, we keep humongous strings in memory.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@mydea mydea Awaiting requested review from mydea

@cleptric cleptric Awaiting requested review from cleptric

Assignees

@lforst lforst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lforst @Lms24