feat(browser): Add http.redirect_count attribute to browser.redirect span
#15943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
changed the title
redirectCount attributeredirectCount attribute to browser.redirect span
Lms24
changed the title
redirectCount attribute to browser.redirect spanhttp.redirect_count attribute to browser.redirect span
size-limit report 📦
|
Lms24
commented
Apr 1, 2025
There was a problem hiding this comment.
I decided to only unit-test this because I couldn't find a way to easily simulate redirects in our playwright integration test setup. If reviewers prefer, I can add a redirection in an e2e test app where this might be easier.
lforst
approved these changes
Apr 1, 2025
s1gr1d
approved these changes
Apr 1, 2025
Lms24
force-pushed
the
lms/feat-browser-redirect-count
branch
from
305e56b to
9e95bcd
Compare
onurtemizkan
pushed a commit
that referenced
this pull request
Apr 3, 2025
…ct` span (#15943) Adds an `http.redirect_count` attribute to `browser.redirect` spans. The count is taken from the `navigation` performance entry and it describes the number of times a redirect happened. Two caveats: - we can't detect more about redirects (e.g. the location the browser was redirected to) - this only works for same-origin redirects. [According to MDN](https://developer.mozilla.org/en-US/docs/Web/API/PerformanceNavigationTiming/redirectCount#value), cross-origin redirects are not taken into account.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
http.redirect_countattribute tobrowser.redirectspans. The count is taken from thenavigationperformance entry and it describes the number of times a redirect happened.Two caveats: