fix(react): Fix Redux integration failing with reducer injection #16106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Override replaceReducer functiont so any lazy loaded injection will reinsert the sentry reducer in the chain
Add a test to verify that redux enhancer is still calling setContext with updated store avec reducer being replaced
Lms24
changed the title
Lms24
reviewed
Apr 22, 2025
There was a problem hiding this comment.
Hey @AntoineDuComptoirDesPharmacies thanks for contributing!
I made an adjustment to your PR title for better readability and requested a review from @s1gr1d (as requested in the issue). Please feel free to add any details to your PR description (if necessary). I also started CI for you (needs an approval since you're a first-time contributor).
Will leave the rest up to Sigrid.
Thanks again!
3 tasks
To keep correct typescript type, use "Proxy" instead of plain object. @s1gr1d I am wondering if we can do better than accessing the index [0] directly ?
s1gr1d
approved these changes
Apr 23, 2025
s1gr1d
reviewed
Apr 23, 2025
| // eslint-disable-next-line @typescript-eslint/unbound-method | ||
| store.replaceReducer = new Proxy(store.replaceReducer, { | ||
| apply: function (target, thisArg, args) { | ||
| target.apply(thisArg, [sentryWrapReducer(args[0])]); |
There was a problem hiding this comment.
Just saw your question here: LeComptoirDesPharmacies@631f71e
I am wondering if we can do better than accessing the index [0] directly ?
Not really as we need to use the first argument :/
Run fix:prettier
onurtemizkan
pushed a commit
that referenced
this pull request
Apr 24, 2025
) Before submitting a pull request, please take a look at our [Contributing](https://github.com/getsentry/sentry-javascript/blob/master/CONTRIBUTING.md) guidelines and verify: - [ X ] If you've added code that should be tested, please add tests. - [ X ] Ensure your code lints and the test suite passes (`yarn lint`) & (`yarn test`).
mydea
pushed a commit
that referenced
this pull request
Apr 25, 2025
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #16106 Co-authored-by: s1gr1d <32902192+s1gr1d@users.noreply.github.com>
3 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).