Skip to content

feat(replay): Extend default list for masking with aria-label #16192

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
May 14, 2025

Conversation

chargome
Copy link
Member

@chargome chargome commented May 5, 2025

closes #16176

@chargome chargome self-assigned this May 5, 2025
@chargome chargome requested a review from a team as a code owner May 5, 2025 09:53
Copy link
Contributor

github-actions bot commented May 5, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.96 kB - -
@sentry/browser - with treeshaking flags 23.62 kB - -
@sentry/browser (incl. Tracing) 38.21 kB - -
@sentry/browser (incl. Tracing, Replay) 76.33 kB +0.01% +7 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 69.36 kB +0.02% +9 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 81.1 kB +0.02% +9 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 93.19 kB +0.01% +4 B 🔺
@sentry/browser (incl. Feedback) 40.76 kB - -
@sentry/browser (incl. sendFeedback) 28.7 kB - -
@sentry/browser (incl. FeedbackAsync) 33.58 kB - -
@sentry/react 25.77 kB - -
@sentry/react (incl. Tracing) 40.21 kB - -
@sentry/vue 28.34 kB - -
@sentry/vue (incl. Tracing) 40 kB - -
@sentry/svelte 23.99 kB - -
CDN Bundle 25.17 kB - -
CDN Bundle (incl. Tracing) 38.23 kB - -
CDN Bundle (incl. Tracing, Replay) 74.12 kB +0.02% +9 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 79.55 kB +0.02% +9 B 🔺
CDN Bundle - uncompressed 73.44 kB - -
CDN Bundle (incl. Tracing) - uncompressed 113.15 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 227.12 kB +0.01% +13 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 239.94 kB +0.01% +13 B 🔺
@sentry/nextjs (client) 41.86 kB - -
@sentry/sveltekit (client) 38.68 kB - -
@sentry/node 158 kB +0.01% +1 B 🔺
@sentry/node - without tracing 97.9 kB - -
@sentry/aws-serverless 123.24 kB - -

View base workflow run

Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add some kind of test for this?

@chargome chargome requested a review from billyvg May 14, 2025 12:09
@chargome chargome enabled auto-merge (squash) May 14, 2025 12:09
@chargome chargome merged commit e00cb04 into develop May 14, 2025
159 checks passed
@chargome chargome deleted the cg-replay-mask-aria branch May 14, 2025 12:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aria-labels should probably be scrubbed
3 participants