Skip to content

fix(remix): Use generic types for ServerBuild argument and return #16336

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
May 20, 2025

Conversation

onurtemizkan
Copy link
Collaborator

@onurtemizkan onurtemizkan commented May 19, 2025

Closes: #15615
Ref: #15615 (comment)

Looks like createRequestHandler exported from @shopify/remix-oxygen does not accept a function that returns/resolves a ServerBuild. It only accepts a plain ServerBuild.

@onurtemizkan onurtemizkan changed the title fix(remix): Accept and return plain ServerBuild on Cloudflare fix(remix): Use generic types for ServerBuild argument and return May 20, 2025
@AbhiPrasad AbhiPrasad merged commit 4a88835 into develop May 20, 2025
37 checks passed
@AbhiPrasad AbhiPrasad deleted the onur/remix-hydrogen-build-return branch May 20, 2025 14:08
AbhiPrasad pushed a commit that referenced this pull request May 29, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated vendored remix types causing typescript errors when instrumenting build
3 participants