Skip to content

fix(browser): Ensure logs are flushed when sendClientReports=false #16351

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

mydea
Copy link
Member

@mydea mydea commented May 21, 2025

This was tied together and could theoretically result in logs not being flushed correctly, when users opt-out of client reports.

Noticed this while scanning over the browser client code :)

This was tied together and could theoretically result in logs not being flushed correctly, when users opt-out of client reports.
@mydea mydea requested a review from AbhiPrasad May 21, 2025 08:40
@mydea mydea self-assigned this May 21, 2025
Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.95 kB +0.02% +4 B 🔺
@sentry/browser - with treeshaking flags 23.72 kB +0.03% +7 B 🔺
@sentry/browser (incl. Tracing) 38.27 kB +0.03% +9 B 🔺
@sentry/browser (incl. Tracing, Replay) 76.39 kB +0.02% +9 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 69.5 kB +0.02% +8 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 81.17 kB +0.02% +9 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 93.26 kB +0.01% +8 B 🔺
@sentry/browser (incl. Feedback) 40.72 kB +0.02% +6 B 🔺
@sentry/browser (incl. sendFeedback) 28.68 kB +0.04% +9 B 🔺
@sentry/browser (incl. FeedbackAsync) 33.57 kB +0.03% +7 B 🔺
@sentry/react 25.73 kB +0.02% +5 B 🔺
@sentry/react (incl. Tracing) 40.25 kB +0.02% +8 B 🔺
@sentry/vue 28.35 kB +0.03% +7 B 🔺
@sentry/vue (incl. Tracing) 40.1 kB +0.03% +9 B 🔺
@sentry/svelte 23.98 kB +0.03% +7 B 🔺
CDN Bundle 25.25 kB +0.05% +11 B 🔺
CDN Bundle (incl. Tracing) 38.39 kB +0.05% +16 B 🔺
CDN Bundle (incl. Tracing, Replay) 74.25 kB +0.03% +20 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 79.67 kB +0.02% +11 B 🔺
CDN Bundle - uncompressed 73.67 kB +0.05% +35 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 113.69 kB +0.04% +35 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 227.66 kB +0.02% +35 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 240.49 kB +0.02% +35 B 🔺
@sentry/nextjs (client) 41.91 kB +0.02% +7 B 🔺
@sentry/sveltekit (client) 38.75 kB +0.03% +11 B 🔺
@sentry/node 149.47 kB - -
@sentry/node - without tracing 98.1 kB - -
@sentry/aws-serverless 123.43 kB - -

View base workflow run

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@mydea mydea merged commit 9a185ee into develop May 21, 2025
126 checks passed
@mydea mydea deleted the fn/flush-browser-logs branch May 21, 2025 14:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants