fix(node): Ensure adding sentry-trace and baggage headers via SentryHttpInstrumentation doesn't crash #16473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SentryHttpInstrumentation doesn't crash On Node > 22.10.0, when spans are off, the `SentryHttpInstrumentation` attempts adding `sentry-trace` and `baggage` headers to requests. Due to race-conditions, this can error in cases where the request was already sent/finished prior to setting the headers. This fix prevents this by wrapping the logic in a try/catch. Fixes: #16438
andreiborza
changed the title
size-limit report 📦
|
AbhiPrasad
approved these changes
Jun 3, 2025
There was a problem hiding this comment.
Due to race-conditions, this can error in cases where the request was already sent/finished prior to setting the headers
Doesn't this mean tracing is broken for those requests? Can we add a test that simulates those conditions?
I approved so we can unblock a merge, we probably want to do a release.
Lms24
approved these changes
Jun 3, 2025
chargome
approved these changes
Jun 3, 2025
3 tasks
I tried adding a test but couldn't :( Tracing is broken for those requests yea, but there's nothing we can do. The requests are already finished by the time this reaches us. Will merge for now. |
andreiborza
deleted the
ab/avoid-setting-headers-on-already-finished-requests
branch
3 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Node > 22.10.0, when spans are off, the
SentryHttpInstrumentationattempts addingsentry-traceandbaggageheaders to requests. Due to race-conditions, this can error in cases where the request was already sent/finished prior to setting the headers.This fix prevents this by wrapping the logic in a try/catch.
Fixes: #16438