Skip to content

Update raven option typings #811

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Jan 10, 2017
Merged

Update raven option typings #811

merged 2 commits into from
Jan 10, 2017

Conversation

connor4312
Copy link
Contributor

Previously a bunch of options were missing from Raven and several methods claimed to take options that they didn't I've updated these based on my understanding of the Raven source and usage within out application.

@mattrobenolt
Copy link
Contributor

With us not being TypeScript experts, is there a way that we can automate this and have a test to assert that the TypeScript interface is always correct when we change public APIs? That way we can catch issues in CI before things get merged.

@connor4312
Copy link
Contributor Author

Not that I'm aware of, unfortunately. If you're not opposed to writing TypeScript, you could move your tests to use TypeScript and thereby assert that all functionality that's tested in typed correctly, but there's not a way to statically determine that typings are correct based only on the original JavaScript.

@FdezRomero
Copy link

Can anyone review this and merge if it's ok? The current Typescript definition doesn't allow to configure autoBreadcrumbs as well as other missing options.

Thanks!

@benvinegar benvinegar merged commit 508121f into getsentry:master Jan 10, 2017
@colinfindlay-nz
Copy link

I'm also needing this. How often is a point release done? This is a reasonably big blocker for using Raven with TypeScript.

@benvinegar
Copy link
Contributor

@silver2k – need to address #820 first.

benvinegar added a commit that referenced this pull request Jan 20, 2017
benvinegar added a commit that referenced this pull request Jan 20, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants