Skip to content

Add a Pull Request template #859

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 24 commits into from
Closed

Conversation

LucaVazz
Copy link
Contributor

@LucaVazz LucaVazz commented Feb 19, 2017

This is intended to ease the process of reviewing and integrating Pull Requests from the community.

The Idea for the Template was originally brought up during #827 by @connor4312.

A note about the long list of commits: After #827 is merged, only the second to last commit is relevant.

- added missing public functions from raven.js
- moved complex data types into helper interfaces
- corrected wrong definitions
- reordered things a bit
@benvinegar
Copy link
Contributor

@LucaVazz – I appreciate the contribution, but I felt this template was a little more intense than I was going for. I've added something a little more concise in #902.

@benvinegar benvinegar closed this Mar 23, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants