Fix export for Raven ambient definition #892
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ipt based projects.
|
Seems travis build is failing, but works for me and my build locally on TS 2.1.6, annoying. Any ideas? |
I am probably the last person to offer ideas :) At this point in time, after the debacle of #898, I am hesitant to accept any change to the TS module definition. |
|
With #977 this should be already fixed. Do you agree with that and closing the PR @jimmythecoder? |
|
This is fixed now. Closing. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix TypeScript export for Raven ambient definition so can be included in projects using TypeScript. Currently due to the export statement, there is no namespace and so you cannot use Raven as it is not found. This is if you included raven as a script dependency in your HTML rather than doing a require and so becomes an ambient lib. It should follow the conventions of other library .d.ts files such as jQuery or underscore which always export a default namespace.
All tests passing.