-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat: Add Bun SDK #9029
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: Add Bun SDK #9029
Conversation
size-limit report 📦
|
try rebasing re: the circular dep checks - we ran into this in #8933 and fixed it there
Can we try adding a quick bun CLI command to see if there is any output? - name: Set up Bun
uses: oven-sh/setup-bun@v1
- name: Test Bun
run: bun help |
I only fixed it for sentry-javascript/packages/node/package.json Lines 75 to 81 in 4a4366d
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass; gonna look at the circular deps issue next...
"publishConfig": { | ||
"access": "public" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine (no action required) but just to note: With this PR we will not yet publish the Bun SDK because it's not configured in craft.yml
. We can tackle this in a follow-up PR!
"@sentry/utils": "7.69.0" | ||
}, | ||
"devDependencies": { | ||
"bun-types": "latest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder how we can say what versions of Bun we support 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't bother too much, let's lock in once we know 😬
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
Opened #9042 for all follow up tasks after we merge this in |
circularDepCheck
is failing for reasons I don't understand - we have the same dep chain in node and doesn't fail thereNice to have:
Bun.serve
for auto instrumentation of transactionsref: #7979
Docs: getsentry/sentry-docs#7858
Platform Icon: getsentry/platformicons#102