fix(node): ANR fixes and additions #9998
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few fixes and additions to the ANR feature.
sdk
property with the event sinceenhanceEventWithSdkInfo
results in duplicate integrations/packages being sent!staticTags
to attach to ANR eventsprocess/origin/environment
The path normalisation code (and tests) are from the Electron SDK and is well tested on all platforms. However, it will only be called when
appRootPath
is supplied. If/when we add path normalisation to Node, it will have a default which can be overridden.The Electron SDK will then wrap the Node Anr integration something like this: