Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(plugin): dont use latest.release as default for the KMP dependency #262

Merged
merged 7 commits into from
Sep 5, 2024

Conversation

buenaflor
Copy link
Contributor

📜 Description

Don't always use latest version.

💡 Motivation and Context

Keeps versioning predictable

💚 How did you test it?

Unit test

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.

🔮 Next steps

@buenaflor buenaflor requested a review from romtsn as a code owner September 3, 2024 11:37
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 16e93e6

@buenaflor buenaflor changed the title feat(plugin): dont use latest.release for the KMP dependency in the plugin feat(plugin): dont use latest.release as default for the KMP dependency in the plugin Sep 3, 2024
@buenaflor buenaflor changed the title feat(plugin): dont use latest.release as default for the KMP dependency in the plugin feat(plugin): dont use latest.release as default for the KMP dependency Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.43%. Comparing base (e88e2d0) to head (16e93e6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #262   +/-   ##
=======================================
  Coverage   75.43%   75.43%           
=======================================
  Files          38       38           
  Lines         574      574           
  Branches       85       85           
=======================================
  Hits          433      433           
  Misses         96       96           
  Partials       45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor buenaflor merged commit 5eed211 into main Sep 5, 2024
12 checks passed
@buenaflor buenaflor deleted the feat/plugin-set-kmp-version branch September 5, 2024 22:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants