adds JSON_ERROR_NON_BACKED_ENUM
to allowed JSON::encode()
errors.
#1707
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
JSON_ERROR_NON_BACKED_ENUM
error code is not yet documented (see php/doc-en#2747), but it is returned when trying to encode encode a non-backed enum to JSON.Since this error code is semantically equivalent to
JSON_ERROR_UNSUPPORTED_TYPE
which is already in the allow list, it makes sense to also add it.For context, I was adding a Monolog record as a Breadcrumd metadata item, which looked like this:
The encoding error is triggered by
Doctrine\DBAL\ParameterType
, which is a unit enum in Doctrine DBAL v4.Since the
JSON_ERROR_NON_BACKED_ENUM
is not handled byJSON::encode()
, this caused an exception to be thrown inPayloadSerializerInterface::serialize()
and as a result the whole event was ignored (nothing was sent to the sentry endpoint).