Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add timing span when emiting a timing metric #1717

Merged
merged 4 commits into from
May 24, 2024
Merged

Add timing span when emiting a timing metric #1717

merged 4 commits into from
May 24, 2024

Conversation

cleptric
Copy link
Member

@cleptric cleptric commented Mar 8, 2024

No description provided.

@cleptric cleptric self-assigned this Mar 8, 2024
cleptric
cleptric commented Mar 11, 2024
View reviewed changes
src/Metrics/Metrics.php Outdated Show resolved Hide resolved
@cleptric cleptric requested a review from stayallive April 2, 2024 14:51
stayallive
stayallive approved these changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good!

@cleptric cleptric marked this pull request as ready for review May 24, 2024 12:23
@cleptric cleptric merged commit e26ecf8 into master May 24, 2024
31 checks passed
@cleptric cleptric deleted the timing-spans branch May 24, 2024 12:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@stayallive stayallive stayallive approved these changes

Assignees

@stayallive stayallive

@cleptric cleptric

Labels
Type: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cleptric @stayallive