Revert ignoring fatal errors on PHP 7+

[Jean85]

This PR attempts to fix #552 allowing all fatals to be captured, with no exception anymore. This is because further investigations lead to discover that the issues in double or loop reporting of fatals where due to a bug on Symfony: see the issue symfony/symfony#26438 and the fix symfony/symfony#26568.

Eventual double reporting should be not fixed here in the client, but on the native integrations, like in the Symfony Bundle.

This PR also adds a regression test with a PHPT test, which could be run with PHPUnit with no issues.

[dcramer]

fwiw the core client should handle double reporting when it can (I think it does/did?). No reason to re-write the same thing.

[Jean85]

@dcramer that kind of stuff is requested in #563. The kind of duplication that I'm talking about here is different, is due to third party integrations, and the scenario is like:

• a fatal error is thrown
• Sentry captures it correctly through the ErrorHandler::handleError function
• Sentry the passes the error to the previous error handler
• The previous error handler is Symfony's, which rethrows errors as FatalThrowableError exceptions
• Sentry's exception handler kicks in...

In this way the error is reported twice, once as an error, once as a FatalThrowableError. Since those are different, the core cannot handle it in itself, but a simple ignore_fatal_throwables option on the Symfony bundle could fix this easily.

[dcramer]

@Jean85 ah nevermind then - agreed.

[stayallive]

👍

[Jean85]

With this I think it's time to release 1.8.4... @stayallive what do you think? We need to update the changelog too!

[stayallive]

Release in https://github.com/getsentry/sentry-php/releases/tag/1.8.4.

[mfb]

Another bug I'd suggest looking at re: fatal errors is #391 - I pushed some code that can fix the bug, or perhaps some other refactoring is desired