Avoid double reporting due to ErrorExceptions #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions being thrown
Jean85
force-pushed
the
avoid-double-reporting
branch
from
aecf7e3 to
c553978
Compare
Jean85
changed the title
stayallive
approved these changes
Mar 21, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two regression PHPT tests to solve the issue of double-reporting errors under PHP 7+, due to the rethrowing of
E_ERRORas anErrorExceptionI'm not sure how to solve this issue, but at least this is a start. Thanks to @mfb for giving me the repro scripts in #552 (comment)